Contributing to Simple API

[Adam Ibrahim <ib...@gmail.com>]

Hello,

I started using this for a project of mine, which required that I adjust
the padding of a cell in a table. I couldn't find how to do that in the
simple API, so I added it myself to the simple API.

How would I contribute this change?
I also have a bug report to submit, and I'm not sure if you guys have some
specific standards to follow, beyond some minimum sample code displaying
the behavior and a description of the bug.

From,
Adam Ibrahim

Re: Contributing to Simple API

[Adam Ibrahim <ib...@gmail.com>]

Alright. Thank you to you both. I put up an issue about it on JIRA. Let me
know how it goes and if there's anything further that I should do.

On Fri, Aug 31, 2018 at 4:41 AM, Michael Stahl <ms...@libreoffice.org> wrote:

>
> hi Adam,
>
> On 31.08.2018 03:41, Adam Ibrahim wrote:
>
>> create a JIRA issue adding all necessary description and attach your
>>>
>> patch to it.
>>
>> I'm not sure how to create the patch. How would I do so/what tools would I
>> need to do so? I looked up git-format-patch on my computer, but the output
>> of that seemed very wrong; it was far too large for the changed I'd made.
>>
>
> the typical way to create a patch is to use "git commit" to first have a
> commit, then use "git format-patch -1" to convert the "head" commit in the
> repo to a patch file; the file will be named "0001-....patch", and you can
> then check it in a text editor.
>

Re: Contributing to Simple API

[Michael Stahl <ms...@libreoffice.org>]

hi Adam,

On 31.08.2018 03:41, Adam Ibrahim wrote:
>> create a JIRA issue adding all necessary description and attach your
> patch to it.
> 
> I'm not sure how to create the patch. How would I do so/what tools would I
> need to do so? I looked up git-format-patch on my computer, but the output
> of that seemed very wrong; it was far too large for the changed I'd made.

the typical way to create a patch is to use "git commit" to first have a 
commit, then use "git format-patch -1" to convert the "head" commit in 
the repo to a patch file; the file will be named "0001-....patch", and 
you can then check it in a text editor.

Re: Contributing to Simple API

[Adam Ibrahim <ib...@gmail.com>]

> create a JIRA issue adding all necessary description and attach your
patch to it.

I'm not sure how to create the patch. How would I do so/what tools would I
need to do so? I looked up git-format-patch on my computer, but the output
of that seemed very wrong; it was far too large for the changed I'd made.

On Fri, Aug 17, 2018 at 6:51 AM, Svante Schubert <sv...@gmail.com>
wrote:

> Hello Adam,
>
> To me, the best way is that you create a JIRA issue adding all necessary
> description and attach your patch to it.
> Our JIRA can be found at https://issues.apache.org/jira/browse/ODFTOOLKIT
> One of the committers will do a code review and push your changes to the
> repository.
>
> Have a nice weekend,
> Svante
>
> Am Di., 14. Aug. 2018 um 01:03 Uhr schrieb Adam Ibrahim <
> ibrahimadam193@gmail.com>:
>
> > Hello,
> >
> > I started using this for a project of mine, which required that I adjust
> > the padding of a cell in a table. I couldn't find how to do that in the
> > simple API, so I added it myself to the simple API.
> >
> > How would I contribute this change?
> > I also have a bug report to submit, and I'm not sure if you guys have
> some
> > specific standards to follow, beyond some minimum sample code displaying
> > the behavior and a description of the bug.
> >
> > From,
> > Adam Ibrahim
> >
>

Re: Contributing to Simple API

[Svante Schubert <sv...@gmail.com>]

Hello Adam,

To me, the best way is that you create a JIRA issue adding all necessary
description and attach your patch to it.
Our JIRA can be found at https://issues.apache.org/jira/browse/ODFTOOLKIT
One of the committers will do a code review and push your changes to the
repository.

Have a nice weekend,
Svante

Am Di., 14. Aug. 2018 um 01:03 Uhr schrieb Adam Ibrahim <
ibrahimadam193@gmail.com>:

> Hello,
>
> I started using this for a project of mine, which required that I adjust
> the padding of a cell in a table. I couldn't find how to do that in the
> simple API, so I added it myself to the simple API.
>
> How would I contribute this change?
> I also have a bug report to submit, and I'm not sure if you guys have some
> specific standards to follow, beyond some minimum sample code displaying
> the behavior and a description of the bug.
>
> From,
> Adam Ibrahim
>