[GitHub] [accumulo] hkeebler commented on a change in pull request #1330: Fix #1090 Consolidate/Simplfy ServerOpts

[GitBox <gi...@apache.org>]

hkeebler commented on a change in pull request #1330: Fix #1090 Consolidate/Simplfy ServerOpts
URL: https://github.com/apache/accumulo/pull/1330#discussion_r320434165
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/cli/ConfigOpts.java
 ##########
 @@ -57,6 +69,9 @@ public synchronized String getPropertiesPath() {
           + " set in Zookeeper). Expected format: -o <key>=<value>")
   private List<String> overrides = new ArrayList<>();
 
+  // holds property overrides that may be generated from deprecation:
+  private static List<String> deprecated_overrides = new ArrayList<>();
 
 Review comment:
   So...I believe we are saying that the best path forward at this time is to do something similar to how ClientOpts is handling legacy (or dropped) options.  No deprecation and auto setting properties.  This definitely simplifies things and keeps the code tidier.   Since these are command line options, dropping them instead of "deprecating" them is not so bad since they are easily updated by the customer vs. "deprecated" java code.  The worst case being that customer generated scripts may need to be updated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services