You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2022/08/31 14:49:14 UTC

[Impala-ASF-CR] IMPALA-11528: Catalogd should start up with a corrupt Hive function.

Hello Tamas Mate, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18927

to look at the new patch set (#8).

Change subject: IMPALA-11528: Catalogd should start up with a corrupt Hive function.
......................................................................

IMPALA-11528: Catalogd should start up with a corrupt Hive function.

This commit handles the case for a specific kind of corrupt function
within the Hive Metastore in the following situation:

A valid Hive SQL function gets created in HMS. This UDF is written in
Java and must derive from the "UDF" class. After creating this function
in Impala, we then replace the underlying jar file with a class that
does NOT derive from the "UDF" class.

In this scenario, catalogd should reject the function and still start
up gracefully. Before this commit, catalogd wasn't coming up. The
reason for this was because the Hive function
FunctionUtils.getUDFClassType() has a dependency on UDAF and was
throwing a LinkageError exception, so we need to include the UDAF
class in the shaded jar.

Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112
---
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
A java/test-corrupt-hive-udfs/pom.xml
A java/test-corrupt-hive-udfs/src/main/java/org/apache/impala/CorruptUdf.java
A java/test-hive-udfs/src/main/java/org/apache/impala/CorruptUdf.java
M testdata/bin/copy-udfs-udas.sh
M tests/custom_cluster/test_permanent_udfs.py
8 files changed, 150 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/18927/8
-- 
To view, visit http://gerrit.cloudera.org:8080/18927
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112
Gerrit-Change-Number: 18927
Gerrit-PatchSet: 8
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>