[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #220: [FLINK-31325] Improve performance of Swing

["zhipeng93 (via GitHub)" <gi...@apache.org>]

zhipeng93 commented on code in PR #220:
URL: https://github.com/apache/flink-ml/pull/220#discussion_r1163692614


##########
flink-ml-lib/src/main/java/org/apache/flink/ml/recommendation/swing/Swing.java:
##########
@@ -147,9 +148,11 @@ public Table[] transform(Table... inputs) {
                                 new ComputingSimilarItems(
                                         getK(),
                                         getMaxUserNumPerItem(),
+                                        getMaxUserBehavior(),

Review Comment:
   After offlinediscussion, we agree to keep the current parameter name to be consistent with the official Swing implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org