You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/31 10:28:42 UTC

[GitHub] [airflow] BorysWix opened a new pull request #15106: Fixing SlackAPIFileOperator

BorysWix opened a new pull request #15106:
URL: https://github.com/apache/airflow/pull/15106


   Details https://github.com/apache/airflow/issues/14880


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #15106: Fixing SlackAPIFileOperator

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #15106:
URL: https://github.com/apache/airflow/pull/15106#issuecomment-812861664


   Can you add tests to avoid regression?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal edited a comment on pull request #15106: Fixing SlackAPIFileOperator

Posted by GitBox <gi...@apache.org>.
eladkal edited a comment on pull request #15106:
URL: https://github.com/apache/airflow/pull/15106#issuecomment-822347893


   Borys won't be able to complete this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal closed pull request #15106: Fixing SlackAPIFileOperator

Posted by GitBox <gi...@apache.org>.
eladkal closed pull request #15106:
URL: https://github.com/apache/airflow/pull/15106


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15106: Fixing SlackAPIFileOperator

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #15106:
URL: https://github.com/apache/airflow/pull/15106#issuecomment-810958304


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโ€™s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better ๐Ÿš€.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #15106: Fixing SlackAPIFileOperator

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15106:
URL: https://github.com/apache/airflow/pull/15106#issuecomment-811026232


   [The Workflow run](https://github.com/apache/airflow/actions/runs/704934911) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on pull request #15106: Fixing SlackAPIFileOperator

Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #15106:
URL: https://github.com/apache/airflow/pull/15106#issuecomment-822347893


   Borys won't be able to complete this PR closing for now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] michaelosthege commented on pull request #15106: Fixing SlackAPIFileOperator

Posted by GitBox <gi...@apache.org>.
michaelosthege commented on pull request #15106:
URL: https://github.com/apache/airflow/pull/15106#issuecomment-822288858


   The code from this PR didn't work for me (using the SlackHook directly from `PythonOperator`).
   Maybe I did something wrong, but what works for me (Airflow 2.0.1) is the code from this: https://stackoverflow.com/a/58264852/4473230


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org