You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:13:36 UTC
[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #10848: optimize select group by having with calcite
codecov-commenter edited a comment on pull request #10848:
URL: https://github.com/apache/shardingsphere/pull/10848#issuecomment-863279236
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10848?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10848](https://codecov.io/gh/apache/shardingsphere/pull/10848?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5bec99f) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5784f46b7fd60f26b716591bfc2eccd8459e1bef?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5784f46) will **increase** coverage by `0.07%`.
> The diff coverage is `34.78%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/10848?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #10848 +/- ##
============================================
+ Coverage 65.62% 65.70% +0.07%
+ Complexity 705 704 -1
============================================
Files 1797 1795 -2
Lines 30896 30815 -81
Branches 5575 5559 -16
============================================
- Hits 20275 20246 -29
+ Misses 9006 8957 -49
+ Partials 1615 1612 -3
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10848?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...arding/merge/dal/show/LogicTablesMergedResult.java](https://codecov.io/gh/apache/shardingsphere/pull/10848/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvbWVyZ2UvZGFsL3Nob3cvTG9naWNUYWJsZXNNZXJnZWRSZXN1bHQuamF2YQ==) | `78.26% <ø> (ø)` | |
| [...sharding/merge/dal/show/ShowIndexMergedResult.java](https://codecov.io/gh/apache/shardingsphere/pull/10848/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvbWVyZ2UvZGFsL3Nob3cvU2hvd0luZGV4TWVyZ2VkUmVzdWx0LmphdmE=) | `100.00% <ø> (ø)` | |
| [...re/sharding/merge/dql/ShardingDQLResultMerger.java](https://codecov.io/gh/apache/shardingsphere/pull/10848/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvbWVyZ2UvZHFsL1NoYXJkaW5nRFFMUmVzdWx0TWVyZ2VyLmphdmE=) | `69.23% <ø> (+0.34%)` | :arrow_up: |
| [...g/merge/dql/groupby/GroupByMemoryMergedResult.java](https://codecov.io/gh/apache/shardingsphere/pull/10848/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvbWVyZ2UvZHFsL2dyb3VwYnkvR3JvdXBCeU1lbW9yeU1lcmdlZFJlc3VsdC5qYXZh) | `92.53% <ø> (ø)` | |
| [...sql/federate/schema/row/FederateRowEnumerator.java](https://codecov.io/gh/apache/shardingsphere/pull/10848/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9mZWRlcmF0ZS9zY2hlbWEvcm93L0ZlZGVyYXRlUm93RW51bWVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...r/sql/federate/schema/row/FederateRowExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/10848/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9mZWRlcmF0ZS9zY2hlbWEvcm93L0ZlZGVyYXRlUm93RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...federate/schema/table/FederateFilterableTable.java](https://codecov.io/gh/apache/shardingsphere/pull/10848/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9mZWRlcmF0ZS9zY2hlbWEvdGFibGUvRmVkZXJhdGVGaWx0ZXJhYmxlVGFibGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...table/generator/FederateExecutionSQLGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/10848/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9mZWRlcmF0ZS9zY2hlbWEvdGFibGUvZ2VuZXJhdG9yL0ZlZGVyYXRlRXhlY3V0aW9uU1FMR2VuZXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...merge/result/impl/memory/MemoryQueryResultRow.java](https://codecov.io/gh/apache/shardingsphere/pull/10848/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtbWVyZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL21lcmdlL3Jlc3VsdC9pbXBsL21lbW9yeS9NZW1vcnlRdWVyeVJlc3VsdFJvdy5qYXZh) | `100.00% <ø> (+35.00%)` | :arrow_up: |
| [.../token/generator/generic/RemoveTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/10848/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9zcWwvdG9rZW4vZ2VuZXJhdG9yL2dlbmVyaWMvUmVtb3ZlVG9rZW5HZW5lcmF0b3IuamF2YQ==) | `9.52% <ø> (+2.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/shardingsphere/pull/10848/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10848?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10848?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5784f46...5bec99f](https://codecov.io/gh/apache/shardingsphere/pull/10848?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org