You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/05/17 20:24:11 UTC

[GitHub] [trafficcontrol] rob05c opened a new pull request #5858: Fix t3c diff for empty files

rob05c opened a new pull request #5858:
URL: https://github.com/apache/trafficcontrol/pull/5858


   Fixes t3c-diff to report a diff for a new semantically empty file, which causes t3c-apply to create it.
   
   This was a bug, because if another config (like remap.config plugins) references the file, it may be legal to be empty, but ATS will fail to load if it doesn't exist.
   
   No docs, no changelog, no interface change and bug isn't in a release.
   Includes tests.
   
   - [x] This PR is not related to any other Issue
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops ORT
   
   ## What is the best way to verify this PR?
   Run ORT integration tests. Create an empy file in Traffic Ops such as with a location param to a custom file with no other parameters, ensure t3c-apply creates the file.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rawlinp merged pull request #5858: Fix t3c diff for empty files

Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #5858:
URL: https://github.com/apache/trafficcontrol/pull/5858


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org