You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/13 11:48:21 UTC

[GitHub] [airflow] XD-DENG opened a new pull request #20854: AwsAthenaOperator: do not generate client_request_token if not provided

XD-DENG opened a new pull request #20854:
URL: https://github.com/apache/airflow/pull/20854


   This PR aims to remove an unnecessary logic in `AwsAthenaOperator` (and in certain use cases, it may cause confusion)
   
   ## What this PR does
   For `AwsAthenaOperator`, if `client_request_token` is not provided, we should do nothing here, rather than generating a UUID explicitly for it.
   
   ## Why do we need this change
   - According to AWS doc (link provided below), boto3 will autopopulate `ClientRequestToken` if it's not provided. So it's not necessary to generate it explicitly here
   - The current logic means a UUID will be generated when the DAG is being parsed into a DAG object. When we check this DAG object, we will see a "random" `client_request_token`. This may not be desired (for example in the product my team is running, this is causing issue).
   
   ## Reference
   Relevant AWS Doc link: https://boto3.amazonaws.com/v1/documentation/api/1.18.0/reference/services/athena.html?highlight=start_query_execution#Athena.Client.start_query_execution


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil merged pull request #20854: AwsAthenaOperator: do not generate client_request_token if not provided

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #20854:
URL: https://github.com/apache/airflow/pull/20854


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org