You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/06 03:00:01 UTC

[GitHub] [incubator-dolphinscheduler] chengshiwen opened a new pull request #4703: Fix task log disappear after recreating or upgrading helm release

chengshiwen opened a new pull request #4703:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4703


   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   **Fix task log disappear after recreating or upgrading helm release**
   
   This closes #3298
   
   ## Brief change log
   
     - *Alter column host varchar(15) to varchar(135) for long host*
     - *Support to get hostname under kubernetes*
     - *Fix task log disappear after recreating or upgrading helm release*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Manually verified the change by testing locally.*
   
   Video check:
    - link: https://pan.baidu.com/s/1KhS-nTgs-T1iST-kqzF0Hg
    - code: ewh8


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #4703: [1.3.5-prepare][Fix-3298][K8s]Fix task log disappear after recreating or upgrading helm release

Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #4703:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4703#issuecomment-774394611


   good job
   don't forget to submit this PR  to dev 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] chengshiwen commented on a change in pull request #4703: [1.3.5-prepare][Fix-3298][K8s]Fix task log disappear after recreating or upgrading helm release

Posted by GitBox <gi...@apache.org>.
chengshiwen commented on a change in pull request #4703:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4703#discussion_r571355416



##########
File path: dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistryTest.java
##########
@@ -55,7 +56,7 @@ public void testRegistry() throws InterruptedException {
         masterRegistry.registry();
         String masterPath = zookeeperRegistryCenter.getMasterPath();
         TimeUnit.SECONDS.sleep(masterConfig.getMasterHeartbeatInterval() + 2); //wait heartbeat info write into zk node
-        String masterNodePath = masterPath + "/" + (Constants.LOCAL_ADDRESS + ":" + masterConfig.getListenPort());
+        String masterNodePath = masterPath + "/" + (OSUtils.getAddr(Constants.LOCAL_ADDRESS, masterConfig.getListenPort()));

Review comment:
       Resolved by #4704




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #4703: [1.3.5-prepare][Fix-3298][K8s]Fix task log disappear after recreating or upgrading helm release

Posted by GitBox <gi...@apache.org>.
dailidong merged pull request #4703:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4703


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] chengshiwen commented on pull request #4703: [1.3.5-prepare][Fix-3298][K8s]Fix task log disappear after recreating or upgrading helm release

Posted by GitBox <gi...@apache.org>.
chengshiwen commented on pull request #4703:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4703#issuecomment-774394783


   @dailidong Got it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #4703: [1.3.5-prepare][Fix-3298][K8s]Fix task log disappear after recreating or upgrading helm release

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4703:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4703#issuecomment-774387841


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4703&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4703&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4703&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4703&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4703&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4703&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4703&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4703&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4703&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4703&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4703&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4703&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/40.png' alt='44.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4703&metric=new_coverage&view=list) [44.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4703&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4703&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4703&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] lenboo commented on a change in pull request #4703: [1.3.5-prepare][Fix-3298][K8s]Fix task log disappear after recreating or upgrading helm release

Posted by GitBox <gi...@apache.org>.
lenboo commented on a change in pull request #4703:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4703#discussion_r571352277



##########
File path: dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistryTest.java
##########
@@ -55,7 +56,7 @@ public void testRegistry() throws InterruptedException {
         masterRegistry.registry();
         String masterPath = zookeeperRegistryCenter.getMasterPath();
         TimeUnit.SECONDS.sleep(masterConfig.getMasterHeartbeatInterval() + 2); //wait heartbeat info write into zk node
-        String masterNodePath = masterPath + "/" + (Constants.LOCAL_ADDRESS + ":" + masterConfig.getListenPort());
+        String masterNodePath = masterPath + "/" + (OSUtils.getAddr(Constants.LOCAL_ADDRESS, masterConfig.getListenPort()));

Review comment:
       the "/"  can be replaced to  constant variable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #4703: [1.3.5-prepare][Fix-3298][K8s]Fix task log disappear after recreating or upgrading helm release

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #4703:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4703#issuecomment-774387476


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4703?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`1.3.5-prepare@223fe99`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4703/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4703?src=pr&el=tree)
   
   ```diff
   @@               Coverage Diff                @@
   ##             1.3.5-prepare    #4703   +/-   ##
   ================================================
     Coverage                 ?   37.20%           
     Complexity               ?     2594           
   ================================================
     Files                    ?      449           
     Lines                    ?    20310           
     Branches                 ?     2460           
   ================================================
     Hits                     ?     7556           
     Misses                   ?    12035           
     Partials                 ?      719           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4703?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4703?src=pr&el=footer). Last update [223fe99...5a19a3b](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org