You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/12 21:44:10 UTC

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4813: Increase timeout for flaky test

Jackie-Jiang commented on a change in pull request #4813: Increase timeout for flaky test
URL: https://github.com/apache/incubator-pinot/pull/4813#discussion_r345461151
 
 

 ##########
 File path: pinot-core/src/test/java/org/apache/pinot/queries/BaseQueriesTest.java
 ##########
 @@ -97,12 +98,12 @@ protected BrokerResponseNative getBrokerResponseForQuery(String query, PlanMaker
    * @return broker response.
    */
   private BrokerResponseNative getBrokerResponseForQuery(String query, PlanMaker planMaker,
-      Map<String, String> queryOptions) {
+      Map<String, String> queryOptions, long timeout) {
     BrokerRequest brokerRequest = COMPILER.compileToBrokerRequest(query);
     brokerRequest.setQueryOptions(queryOptions);
 
     // Server side.
-    Plan plan = planMaker.makeInterSegmentPlan(getSegmentDataManagers(), brokerRequest, EXECUTOR_SERVICE, 10_000);
 
 Review comment:
   By default, this should be `CommonConstants.Server.DEFAULT_QUERY_EXECUTOR_TIMEOUT_MS`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org