You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/17 11:46:57 UTC
[GitHub] [flink] curcur opened a new pull request #13175: [FLINK-18955] Add checkpoint path to job startup/restore message
curcur opened a new pull request #13175:
URL: https://github.com/apache/flink/pull/13175
## What is the purpose of the change
Add checkpoint path to job startup/restore message to help users identify which checkpoint is used for restoring.
## Brief change log
- add `externalPointer` to the message
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur edited a comment on pull request #13175: [FLINK-18955] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
curcur edited a comment on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-674833835
Test:
It produces something similar to:
`8004 [flink-akka.actor.default-dispatcher-3] INFO org.apache.flink.runtime.checkpoint.CheckpointCoordinator [] - Restoring job 36681198e38a2c91932eb131f47e3641 from checkpoint: Checkpoint 1 @ 1597663438566 for 36681198e38a2c91932eb131f47e3641 located at file:/var/folders/dm/5xn_h6n9135dwy4j27sr65zh0000gp/T/junit492898918775365121/junit2392379173263601046/checkpoints/36681198e38a2c91932eb131f47e3641/chk-1.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #13175:
URL: https://github.com/apache/flink/pull/13175#discussion_r474154852
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
##########
@@ -320,6 +320,12 @@ void setDiscardCallback(@Nullable CompletedCheckpointStats.DiscardCallback disca
@Override
public String toString() {
- return String.format("Checkpoint %d @ %d for %s", checkpointID, timestamp, job);
+ return String.format(
+ "%s %d @ %d for %s located at %s",
+ props.getCheckpointType(),
Review comment:
I guess having a bit technicality in the log should be okay.
Another easy fix would be to override the `toString` in the checkpoint type and output it in more readable form.
"Checkpoint"
"Savepoint"
"Savepoint (sync)"
I also don't know if SYNC_SAVEPOINT would appear in materialized checkpoint at all - might be also some transient information that gets replaced by SAVEPOINT on recovery?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #13175:
URL: https://github.com/apache/flink/pull/13175#discussion_r473935762
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
##########
@@ -320,6 +320,12 @@ void setDiscardCallback(@Nullable CompletedCheckpointStats.DiscardCallback disca
@Override
public String toString() {
- return String.format("Checkpoint %d @ %d for %s", checkpointID, timestamp, job);
+ return String.format(
+ "%s %d @ %d for %s located at %s",
+ props.getCheckpointType(),
Review comment:
Please let me know what do you think :-). I would be happy to change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
curcur commented on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-678391416
With updated version
```
9213 [flink-akka.actor.default-dispatcher-3] INFO org.apache.flink.runtime.checkpoint.CheckpointCoordinator [] - Restoring job 49eabb33b8dfc353a4ca205f5f02b118 from Checkpoint 1 @ 1598017016795 for 49eabb33b8dfc353a4ca205f5f02b118 located at file:/var/folders/dm/5xn_h6n9135dwy4j27sr65zh0000gp/T/junit3638159208308156331/junit7166739105409262417/checkpoints/49eabb33b8dfc353a4ca205f5f02b118/chk-1.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13175: [FLINK-18955] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-674839926
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5608",
"triggerID" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 888d10fb3a82d69704454c3d0e71081e7e1e6b5c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5608)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
curcur commented on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-677043774
```
8366 [flink-akka.actor.default-dispatcher-4] INFO org.apache.flink.runtime.checkpoint.CheckpointCoordinator [] - Restoring job 7aec7905c64fcf38ceb2b86e6193638d from CHECKPOINT 1 @ 1597898260536 for 7aec7905c64fcf38ceb2b86e6193638d located at file:/var/folders/dm/5xn_h6n9135dwy4j27sr65zh0000gp/T/junit495383509976337357/junit8019506371853310216/checkpoints/7aec7905c64fcf38ceb2b86e6193638d/chk-1.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-674839926
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5608",
"triggerID" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"triggerType" : "PUSH"
}, {
"hash" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5643",
"triggerID" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"triggerType" : "PUSH"
}, {
"hash" : "635f839466122e36674a38a9845c2d6b5eb5c244",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5735",
"triggerID" : "635f839466122e36674a38a9845c2d6b5eb5c244",
"triggerType" : "PUSH"
}, {
"hash" : "78f6ef8e0aa36ddc08ecd4a6984ec465c0192ec7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "78f6ef8e0aa36ddc08ecd4a6984ec465c0192ec7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 635f839466122e36674a38a9845c2d6b5eb5c244 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5735)
* 78f6ef8e0aa36ddc08ecd4a6984ec465c0192ec7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #13175:
URL: https://github.com/apache/flink/pull/13175#discussion_r473929844
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
##########
@@ -320,6 +320,12 @@ void setDiscardCallback(@Nullable CompletedCheckpointStats.DiscardCallback disca
@Override
public String toString() {
- return String.format("Checkpoint %d @ %d for %s", checkpointID, timestamp, job);
+ return String.format(
+ "%s %d @ %d for %s located at %s",
+ props.getCheckpointType(),
Review comment:
I do not have a strong opinion on this as well. But since you ask, let me have a try LOL :-)
The only concern is that we "might" have more types in the future
1. checkpoint or savepoint; 2. Synchronous or not; 3. Global or Individual; 4. unaligned or not (I mean it could be);
- It is a bit difficult to categorize the enum of CheckpointType to just "Checkpoint" and "Savepoint"
- It is also difficult to tell what level of technicality a user needs. For a user that makes an SYNC_SAVEPOINT, he/she probably has enough knowledge to understand what an SYNC_SAVEPOINT is. Or in other words, if we think SYNC_SAVEPOINT is not that understandable, we can improve its expressiveness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-674839926
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5608",
"triggerID" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"triggerType" : "PUSH"
}, {
"hash" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5643",
"triggerID" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"triggerType" : "PUSH"
}, {
"hash" : "635f839466122e36674a38a9845c2d6b5eb5c244",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5735",
"triggerID" : "635f839466122e36674a38a9845c2d6b5eb5c244",
"triggerType" : "PUSH"
}, {
"hash" : "78f6ef8e0aa36ddc08ecd4a6984ec465c0192ec7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5779",
"triggerID" : "78f6ef8e0aa36ddc08ecd4a6984ec465c0192ec7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 635f839466122e36674a38a9845c2d6b5eb5c244 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5735)
* 78f6ef8e0aa36ddc08ecd4a6984ec465c0192ec7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5779)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur removed a comment on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
curcur removed a comment on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-677043774
```
8366 [flink-akka.actor.default-dispatcher-4] INFO org.apache.flink.runtime.checkpoint.CheckpointCoordinator [] - Restoring job 7aec7905c64fcf38ceb2b86e6193638d from CHECKPOINT 1 @ 1597898260536 for 7aec7905c64fcf38ceb2b86e6193638d located at file:/var/folders/dm/5xn_h6n9135dwy4j27sr65zh0000gp/T/junit495383509976337357/junit8019506371853310216/checkpoints/7aec7905c64fcf38ceb2b86e6193638d/chk-1.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13175: [FLINK-18955] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-674839926
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 888d10fb3a82d69704454c3d0e71081e7e1e6b5c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-674839926
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5608",
"triggerID" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"triggerType" : "PUSH"
}, {
"hash" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5643",
"triggerID" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"triggerType" : "PUSH"
}, {
"hash" : "635f839466122e36674a38a9845c2d6b5eb5c244",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5735",
"triggerID" : "635f839466122e36674a38a9845c2d6b5eb5c244",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0cc43ac38a2161bfd6c005782c08d2c70cc47e43 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5643)
* 635f839466122e36674a38a9845c2d6b5eb5c244 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5735)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #13175:
URL: https://github.com/apache/flink/pull/13175
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-674839926
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5608",
"triggerID" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"triggerType" : "PUSH"
}, {
"hash" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5643",
"triggerID" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0cc43ac38a2161bfd6c005782c08d2c70cc47e43 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5643)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #13175:
URL: https://github.com/apache/flink/pull/13175#discussion_r474816716
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
##########
@@ -320,6 +320,12 @@ void setDiscardCallback(@Nullable CompletedCheckpointStats.DiscardCallback disca
@Override
public String toString() {
- return String.format("Checkpoint %d @ %d for %s", checkpointID, timestamp, job);
+ return String.format(
+ "%s %d @ %d for %s located at %s",
+ props.getCheckpointType(),
Review comment:
updated :-)
I can double-check whether SYNC_SAVEPOINT is user-aware or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on pull request #13175: [FLINK-18955] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
curcur commented on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-674833835
Test:
It produces something similar to:
`8004 [flink-akka.actor.default-dispatcher-3] INFO org.apache.flink.runtime.checkpoint.CheckpointCoordinator [] - Restoring job 36681198e38a2c91932eb131f47e3641 from latest valid checkpoint: Checkpoint 1 @ 1597663438566 for 36681198e38a2c91932eb131f47e3641 located at file:/var/folders/dm/5xn_h6n9135dwy4j27sr65zh0000gp/T/junit492898918775365121/junit2392379173263601046/checkpoints/36681198e38a2c91932eb131f47e3641/chk-1.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
curcur commented on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-677059704
Test results after adding including checkpoint type information in `CompletedCheckpoint`
```
8366 [flink-akka.actor.default-dispatcher-4] INFO org.apache.flink.runtime.checkpoint.CheckpointCoordinator [] - Restoring job 7aec7905c64fcf38ceb2b86e6193638d from CHECKPOINT 1 @ 1597898260536 for 7aec7905c64fcf38ceb2b86e6193638d located at file:/var/folders/dm/5xn_h6n9135dwy4j27sr65zh0000gp/T/junit495383509976337357/junit8019506371853310216/checkpoints/7aec7905c64fcf38ceb2b86e6193638d/chk-1.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #13175:
URL: https://github.com/apache/flink/pull/13175#discussion_r473929844
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
##########
@@ -320,6 +320,12 @@ void setDiscardCallback(@Nullable CompletedCheckpointStats.DiscardCallback disca
@Override
public String toString() {
- return String.format("Checkpoint %d @ %d for %s", checkpointID, timestamp, job);
+ return String.format(
+ "%s %d @ %d for %s located at %s",
+ props.getCheckpointType(),
Review comment:
I do not have a strong opinion on this as well. But since you ask, let me have a try LOL :-)
The only concern is that we "might" have more types in the future
1. checkpoint or savepoint; 2. Synchronous or not; 3. Global or Individual; 4. unaligned or not (I mean it could be);
- It is a bit difficult to categorize the enum of CheckpointType to just "Checkpoint" and "Savepoint"
- It is also difficult to tell what level of technicality a user needs. Or in other words, if we think SYNC_SAVEPOINT is not that understandable, we can improve its expressiveness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-674839926
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5608",
"triggerID" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"triggerType" : "PUSH"
}, {
"hash" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5643",
"triggerID" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"triggerType" : "PUSH"
}, {
"hash" : "635f839466122e36674a38a9845c2d6b5eb5c244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5735",
"triggerID" : "635f839466122e36674a38a9845c2d6b5eb5c244",
"triggerType" : "PUSH"
}, {
"hash" : "78f6ef8e0aa36ddc08ecd4a6984ec465c0192ec7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5779",
"triggerID" : "78f6ef8e0aa36ddc08ecd4a6984ec465c0192ec7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 78f6ef8e0aa36ddc08ecd4a6984ec465c0192ec7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5779)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-674839926
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5608",
"triggerID" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"triggerType" : "PUSH"
}, {
"hash" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5643",
"triggerID" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 888d10fb3a82d69704454c3d0e71081e7e1e6b5c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5608)
* 0cc43ac38a2161bfd6c005782c08d2c70cc47e43 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5643)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #13175:
URL: https://github.com/apache/flink/pull/13175#discussion_r473929844
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
##########
@@ -320,6 +320,12 @@ void setDiscardCallback(@Nullable CompletedCheckpointStats.DiscardCallback disca
@Override
public String toString() {
- return String.format("Checkpoint %d @ %d for %s", checkpointID, timestamp, job);
+ return String.format(
+ "%s %d @ %d for %s located at %s",
+ props.getCheckpointType(),
Review comment:
I do not have a strong opinion on this as well. But since you ask, let me have a try LOL :-)
The only concern is that we "might" have more types in the future
1. checkpoint or savepoint; 2. Synchronous or not; 3. Global or Individual; 4. unaligned or not (I mean it could be);
- It is a bit difficult to categorize the enum of CheckpointType to just "Checkpoint" and "Savepoint"
- It is also difficult to tell what level of technicality a user needs. For a user that makes an SYNC_SAVEPOINT, he/she probably has enough knowledge to understand what an SYNC_SAVEPOINT is. Or in other words, if we think SYNC_SAVEPOINT is not that understandable, we probably need to improve its expressiveness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13175: [FLINK-18955] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-674839926
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5608",
"triggerID" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 888d10fb3a82d69704454c3d0e71081e7e1e6b5c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5608)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #13175:
URL: https://github.com/apache/flink/pull/13175#discussion_r472987418
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1293,7 +1293,7 @@ private boolean restoreLatestCheckpointedStateInternal(
}
}
- LOG.info("Restoring job {} from latest valid checkpoint: {}.", job, latest);
+ LOG.info("Restoring job {} from checkpoint: {}.", job, latest);
Review comment:
I don't really see how @NicoK 's suggestion makes it clearer that it could also be a savepoint.
My suggestion would be to encode the type checkpoint/savepoint into `CompletedCheckpoint#toString` and just use: `LOG.info("Restoring job {} from {}.", job, latest);`.
Then the full message would be
```
8004 [flink-akka.actor.default-dispatcher-3] INFO org.apache.flink.runtime.checkpoint.CheckpointCoordinator [] - Restoring job 36681198e38a2c91932eb131f47e3641 from Checkpoint 1 @ 1597663438566 for 36681198e38a2c91932eb131f47e3641 located at file:/var/folders/dm/5xn_h6n9135dwy4j27sr65zh0000gp/T/junit492898918775365121/junit2392379173263601046/checkpoints/36681198e38a2c91932eb131f47e3641/chk-1.
```
instead of
```
8004 [flink-akka.actor.default-dispatcher-3] INFO org.apache.flink.runtime.checkpoint.CheckpointCoordinator [] - Restoring job 36681198e38a2c91932eb131f47e3641 from checkpoint: Checkpoint 1 @ 1597663438566 for 36681198e38a2c91932eb131f47e3641 located at file:/var/folders/dm/5xn_h6n9135dwy4j27sr65zh0000gp/T/junit492898918775365121/junit2392379173263601046/checkpoints/36681198e38a2c91932eb131f47e3641/chk-1.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-678981035
Thanks both of you, merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #13175:
URL: https://github.com/apache/flink/pull/13175#discussion_r473569690
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1293,7 +1293,7 @@ private boolean restoreLatestCheckpointedStateInternal(
}
}
- LOG.info("Restoring job {} from latest valid checkpoint: {}.", job, latest);
+ LOG.info("Restoring job {} from checkpoint: {}.", job, latest);
Review comment:
That's a good idea!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #13175:
URL: https://github.com/apache/flink/pull/13175#discussion_r473766209
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
##########
@@ -320,6 +320,12 @@ void setDiscardCallback(@Nullable CompletedCheckpointStats.DiscardCallback disca
@Override
public String toString() {
- return String.format("Checkpoint %d @ %d for %s", checkpointID, timestamp, job);
+ return String.format(
+ "%s %d @ %d for %s located at %s",
+ props.getCheckpointType(),
Review comment:
Currently that would display:
"CHECKPOINT"
"SAVEPOINT"
"SYNC_SAVEPOINT"
I'm proposing to translate them into just "Checkpoint" and "Savepoint" to reduce the technicality. However, no strong feelings, so you can also convince me that it's better to leave as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-674839926
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5608",
"triggerID" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"triggerType" : "PUSH"
}, {
"hash" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5643",
"triggerID" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"triggerType" : "PUSH"
}, {
"hash" : "635f839466122e36674a38a9845c2d6b5eb5c244",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5735",
"triggerID" : "635f839466122e36674a38a9845c2d6b5eb5c244",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 635f839466122e36674a38a9845c2d6b5eb5c244 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5735)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #13175:
URL: https://github.com/apache/flink/pull/13175#discussion_r474816716
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
##########
@@ -320,6 +320,12 @@ void setDiscardCallback(@Nullable CompletedCheckpointStats.DiscardCallback disca
@Override
public String toString() {
- return String.format("Checkpoint %d @ %d for %s", checkpointID, timestamp, job);
+ return String.format(
+ "%s %d @ %d for %s located at %s",
+ props.getCheckpointType(),
Review comment:
updated :-)
Do you mean SYNC_SAVEPOINT is not user-aware? I do not know...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13175: [FLINK-18955] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-674834232
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 888d10fb3a82d69704454c3d0e71081e7e1e6b5c (Mon Aug 17 11:48:38 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18955).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-674839926
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5608",
"triggerID" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"triggerType" : "PUSH"
}, {
"hash" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 888d10fb3a82d69704454c3d0e71081e7e1e6b5c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5608)
* 0cc43ac38a2161bfd6c005782c08d2c70cc47e43 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13175: [FLINK-18955][Checkpointing] Add checkpoint path to job startup/restore message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13175:
URL: https://github.com/apache/flink/pull/13175#issuecomment-674839926
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5608",
"triggerID" : "888d10fb3a82d69704454c3d0e71081e7e1e6b5c",
"triggerType" : "PUSH"
}, {
"hash" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5643",
"triggerID" : "0cc43ac38a2161bfd6c005782c08d2c70cc47e43",
"triggerType" : "PUSH"
}, {
"hash" : "635f839466122e36674a38a9845c2d6b5eb5c244",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "635f839466122e36674a38a9845c2d6b5eb5c244",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0cc43ac38a2161bfd6c005782c08d2c70cc47e43 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5643)
* 635f839466122e36674a38a9845c2d6b5eb5c244 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org