[GitHub] [druid] a2l007 commented on a change in pull request #10421: Improve lookup state update to avoid query failures

[GitBox <gi...@apache.org>]

a2l007 commented on a change in pull request #10421:
URL: https://github.com/apache/druid/pull/10421#discussion_r505662614



##########
File path: server/src/main/java/org/apache/druid/query/lookup/LookupReferencesManager.java
##########
@@ -587,6 +594,43 @@ private StringFullResponseHolder fetchLookupsForTier(String tier) throws Interru
     void handle(Map<String, LookupExtractorFactoryContainer> lookupMap) throws Exception;
   }
 
+  private static class StatusNotice implements Notice

Review comment:
       Why do we need a separate `StatusNotice`? Can the isReady() check based behavior be integrated into the LoadNotice itself?

##########
File path: server/src/main/java/org/apache/druid/query/lookup/LookupReferencesManager.java
##########
@@ -168,7 +168,7 @@ public void start()
                 while (!Thread.interrupted() && lifecycleLock.awaitStarted(1, TimeUnit.MILLISECONDS)) {
                   try {
                     handlePendingNotices();
-                    LockSupport.parkNanos(LookupReferencesManager.this, TimeUnit.MINUTES.toNanos(1));
+                    LockSupport.parkNanos(LookupReferencesManager.this, TimeUnit.SECONDS.toNanos(1));

Review comment:
       Why is this being changed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org