You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ns...@apache.org on 2011/10/11 04:14:29 UTC

svn commit: r1181505 - /hbase/branches/0.89/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java

Author: nspiegelberg
Date: Tue Oct 11 02:14:29 2011
New Revision: 1181505

URL: http://svn.apache.org/viewvc?rev=1181505&view=rev
Log:
HBase-3665: add assertions to check number of entries Summary: This is a sub task of HBase-3636. Add 2 more assertions to the unit test

Trac Bug: #

Blame Rev:

Reviewed By:
nspiegelberg
Test Plan:
Passing unit test
Revert Plan:

Database Impact:

Memcache Impact:

Other Notes:

EImportant:

- begin *PUBLIC* platform impact section -
Bugzilla: #
- end platform impact -

Modified:
    hbase/branches/0.89/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java

Modified: hbase/branches/0.89/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java?rev=1181505&r1=1181504&r2=1181505&view=diff
==============================================================================
--- hbase/branches/0.89/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java (original)
+++ hbase/branches/0.89/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java Tue Oct 11 02:14:29 2011
@@ -2678,13 +2678,14 @@ public class TestHRegion extends HBaseTe
     int num_unique_rows = 10;
     int duplicate_multiplier =2;
     int num_storefiles = 4;
+    int version = 0;
 
     for (int f =0 ; f < num_storefiles; f++) {
 	for (int i = 0; i < duplicate_multiplier; i ++) {
 		for (int j = 0; j < num_unique_rows; j++) {
 			Put put = new Put(Bytes.toBytes("row" + j));
-			put.add(fam1, qf1, val1);
-			region.put(put);
+			put.add(fam1, qf1, version++, val1);
+          region.put(put);
 		}
 	    }
 	    region.flushcache();
@@ -2696,6 +2697,7 @@ public class TestHRegion extends HBaseTe
 	StoreFile.Reader reader = storefile.getReader();
 	reader.loadFileInfo();
       reader.loadBloomfilter();
+      assertEquals(num_unique_rows * duplicate_multiplier, reader.getEntries());
 	assertEquals(num_unique_rows, reader.getFilterEntries());
     }
 
@@ -2707,7 +2709,9 @@ public class TestHRegion extends HBaseTe
 	StoreFile.Reader reader = storefile.getReader();
 	reader.loadFileInfo();
       reader.loadBloomfilter();
-	assertEquals(num_unique_rows, reader.getFilterEntries());
+	assertEquals(num_unique_rows * duplicate_multiplier * num_storefiles,
+          reader.getEntries());
+      assertEquals(num_unique_rows, reader.getFilterEntries());
     }
 
   }