You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/01/13 06:39:02 UTC

[GitHub] [skywalking-nginx-lua] Frapschen opened a new pull request #62: Fix issue #6168

Frapschen opened a new pull request #62:
URL: https://github.com/apache/skywalking-nginx-lua/pull/62


   remove L50-51 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-nginx-lua] membphis commented on pull request #62: Fix issue #6168

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #62:
URL: https://github.com/apache/skywalking-nginx-lua/pull/62#issuecomment-759241648


   we should delete those lines ^_^
   
   ```
   # This is for local dev only, please do not add this in any production env.
           lua_code_cache off;


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-nginx-lua] JaredTan95 commented on pull request #62: remove the wrong directive in Nginx example

Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on pull request #62:
URL: https://github.com/apache/skywalking-nginx-lua/pull/62#issuecomment-759249502


   > we should delete those lines ^_^
   > 
   > ```
   > # This is for local dev only, please do not add this in any production env.
   >         lua_code_cache off;
   > ```
   
   @Frapschen 
   The same content in README.md could be deleted.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-nginx-lua] JaredTan95 merged pull request #62: remove the wrong directive in Nginx example

Posted by GitBox <gi...@apache.org>.
JaredTan95 merged pull request #62:
URL: https://github.com/apache/skywalking-nginx-lua/pull/62


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org