[jira] [Updated] (HADOOP-8909) Maven protoc calls must not depend on external sh script

["Chris Nauroth (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-8909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Nauroth updated HADOOP-8909:
----------------------------------

    Attachment: HADOOP-8909.patch

The attached patch removes the sh scripting and instead uses exec-maven-plugin, which is the same way that the yarn modules call protoc.  I tested the change successfully on Mac, Windows with Cygwin, and Windows without Cygwin.

There is a small loss of functionality in that the shell script performed wildcard expansion, so that developers could have added new .proto files without needing to make corresponding updates to pom.xml.  Adding new .proto files is a rare event, so this shouldn't be too cumbersome.  There is a Protocol Buffers Maven plugin under development that could solve this more elegantly, but it hasn't been released yet.

                
> Maven protoc calls must not depend on external sh script
> --------------------------------------------------------
>
>                 Key: HADOOP-8909
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8909
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-8909.patch
>
>
> Currently, several pom.xml files rely on external shell scripting to call protoc.  The sh binary may not be available on all developers' machines (e.g. Windows without Cygwin).  This issue tracks removal of that dependency.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira