You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/11 09:05:19 UTC
[GitHub] [superset] zhaoyongjie opened a new pull request, #21766: refactor: preparation for time section migration
zhaoyongjie opened a new pull request, #21766:
URL: https://github.com/apache/superset/pull/21766
### SUMMARY
In order to easily review the Time Section Migration, all refactoring work is done in this PR. This PR shouldn't change any current behaviors.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #21766: refactor: preparation for time section migration
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #21766:
URL: https://github.com/apache/superset/pull/21766#discussion_r992080780
##########
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/index.tsx:
##########
@@ -227,7 +226,7 @@ const time_range: SharedControlConfig<'DateFilterControl'> = {
type: 'DateFilterControl',
freeForm: true,
label: TIME_FILTER_LABELS.time_range,
- default: t('No filter'), // this value is translated, but the backend wouldn't understand a translated value?
+ default: 'No filter', // this value is an empty filter constant so shouldn't translate it.
Review Comment:
Nit: could we place `'No filter'` in a `constants.ts`?
##########
superset-frontend/src/explore/components/controls/DateFilterControl/utils/dateFilterUtils.ts:
##########
@@ -24,11 +35,53 @@ export const buildTimeRangeString = (since: string, until: string): string =>
const formatDateEndpoint = (dttm: string, isStart?: boolean): string =>
dttm.replace('T00:00:00', '') || (isStart ? '-∞' : '∞');
-export const formatTimeRange = (timeRange: string) => {
+export const formatTimeRange = (
+ timeRange: string,
+ columnPlaceholder = 'col',
Review Comment:
nice addition 👍
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -17,75 +17,34 @@
* under the License.
*/
import React, { useState, useEffect, useMemo } from 'react';
-import rison from 'rison';
-import { css, SupersetClient, styled, t, useTheme } from '@superset-ui/core';
-import {
- buildTimeRangeString,
- formatTimeRange,
- COMMON_RANGE_VALUES_SET,
- CALENDAR_RANGE_VALUES_SET,
- FRAME_OPTIONS,
- customTimeRangeDecode,
-} from 'src/explore/components/controls/DateFilterControl/utils';
-import { getClientErrorObject } from 'src/utils/getClientErrorObject';
+import { css, styled, t, useTheme } from '@superset-ui/core';
import Button from 'src/components/Button';
import ControlHeader from 'src/explore/components/ControlHeader';
import Label, { Type } from 'src/components/Label';
import { Divider } from 'src/components';
import Icons from 'src/components/Icons';
import Select from 'src/components/Select/Select';
import { Tooltip } from 'src/components/Tooltip';
-import { DEFAULT_TIME_RANGE } from 'src/explore/constants';
+import { DEFAULT_TIME_RANGE, NO_TIME_RANGE } from 'src/explore/constants';
Review Comment:
..to continue on the previous comment, we should probably move `NO_TIME_RANGE` from `src/` to `@superset-ui/core`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #21766: refactor: preparation for time section migration
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged PR #21766:
URL: https://github.com/apache/superset/pull/21766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org