[GitHub] [hbase] apurtell commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

[GitBox <gi...@apache.org>]

apurtell commented on a change in pull request #3283:
URL: https://github.com/apache/hbase/pull/3283#discussion_r635588417



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryFilterRetryableException.java
##########
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.replication.regionserver;
+
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * This exception should be thrown from any wal filter when the filter is expected
+ * to recover from the failures and it wants the replication to backup till it fails.
+ * There is special handling in replication wal reader to catch this exception and
+ * retry.
+ */
+@InterfaceAudience.Public

Review comment:
       LimitedPrivate only please. This signals how we intend to support it. Public means it is for general use and we will keep it very stable. LP(REPLICATION) seems more than appropriate because this is an internal implementation detail that has become part of the interface contract via this exception. 

##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java
##########
@@ -165,6 +165,12 @@ public void run() {
         } catch (InterruptedException e) {
           LOG.trace("Interrupted while sleeping between WAL reads");
           Thread.currentThread().interrupt();
+        } catch (WALEntryFilterRetryableException e) {

Review comment:
       I'm not really happy with the inheritance from RTE here either but understand the compat issues. Is this the only place this exception will surface? Unhandled RTEs eventually go to the thread's unhandled exception handler, which is rarely what you want to happen. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org