You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joe Smith <ya...@gmail.com> on 2015/05/09 23:54:21 UTC
Review Request 34020: Normalize SLA stat names
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-1282
https://issues.apache.org/jira/browse/AURORA-1282
Repository: aurora
Description
-------
Normalize SLA stat names
This is going to change these metrics from `sla_role/env/job_job_uptime_50.00_sec` to `sla_role_env_job_job_uptime_50_00_sec`
Diffs
-----
src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 82f36d5ca15df18bdc8ebbbd868d3394db38e603
src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164
Diff: https://reviews.apache.org/r/34020/diff/
Testing
-------
[tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test
BUILD SUCCESSFUL
Thanks,
Joe Smith
Re: Review Request 34020: Normalize SLA stat names
Posted by Joe Smith <ya...@gmail.com>.
> On July 5, 2015, 12:49 p.m., Stephan Erb wrote:
> > The same thing should also be applied to https://github.com/apache/aurora/blob/827b9abea48babe53ad5b2c521757c60f04c6dfc/src/main/java/org/apache/aurora/scheduler/TaskVars.java#L110
>
> Bill Farner wrote:
> Good call - are you planning to roll that into this patch?
Yep, good idea, pulled that in as well.
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review90412
-----------------------------------------------------------
On July 30, 2015, 10:32 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 10:32 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Normalize SLA stat names ahead of time- this will prevent spurious log messages.
>
> Stat names will be unchanged as a result of this.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478
>
> Diff: https://reviews.apache.org/r/34020/diff/
>
>
> Testing
> -------
>
> [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test
>
> BUILD SUCCESSFUL
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34020: Normalize SLA stat names
Posted by Bill Farner <wf...@apache.org>.
> On July 5, 2015, 7:49 p.m., Stephan Erb wrote:
> > The same thing should also be applied to https://github.com/apache/aurora/blob/827b9abea48babe53ad5b2c521757c60f04c6dfc/src/main/java/org/apache/aurora/scheduler/TaskVars.java#L110
Good call - are you planning to roll that into this patch?
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review90412
-----------------------------------------------------------
On June 12, 2015, 11:18 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
>
> (Updated June 12, 2015, 11:18 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Normalize SLA stat names ahead of time- this will prevent spurious log messages.
>
> Stat names will be unchanged as a result of this.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 82f36d5ca15df18bdc8ebbbd868d3394db38e603
> src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164
>
> Diff: https://reviews.apache.org/r/34020/diff/
>
>
> Testing
> -------
>
> [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test
>
> BUILD SUCCESSFUL
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34020: Normalize SLA stat names
Posted by Stephan Erb <st...@dev.static-void.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review90412
-----------------------------------------------------------
The same thing should also be applied to https://github.com/apache/aurora/blob/827b9abea48babe53ad5b2c521757c60f04c6dfc/src/main/java/org/apache/aurora/scheduler/TaskVars.java#L110
- Stephan Erb
On June 13, 2015, 1:18 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
>
> (Updated June 13, 2015, 1:18 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Normalize SLA stat names ahead of time- this will prevent spurious log messages.
>
> Stat names will be unchanged as a result of this.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 82f36d5ca15df18bdc8ebbbd868d3394db38e603
> src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164
>
> Diff: https://reviews.apache.org/r/34020/diff/
>
>
> Testing
> -------
>
> [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test
>
> BUILD SUCCESSFUL
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34020: Normalize SLA stat names
Posted by Joe Smith <ya...@gmail.com>.
> On July 8, 2015, 10:49 a.m., Stephan Erb wrote:
> > Joe, have you tested this change in vagrant?
I decided to change direction here, so we won't be changing stats names.
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review90933
-----------------------------------------------------------
On July 30, 2015, 10:32 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 10:32 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Normalize SLA stat names ahead of time- this will prevent spurious log messages.
>
> Stat names will be unchanged as a result of this.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478
>
> Diff: https://reviews.apache.org/r/34020/diff/
>
>
> Testing
> -------
>
> [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test
>
> BUILD SUCCESSFUL
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34020: Normalize SLA stat names
Posted by Stephan Erb <st...@dev.static-void.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review90933
-----------------------------------------------------------
Joe, have you tested this change in vagrant?
- Stephan Erb
On June 13, 2015, 1:18 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
>
> (Updated June 13, 2015, 1:18 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Normalize SLA stat names ahead of time- this will prevent spurious log messages.
>
> Stat names will be unchanged as a result of this.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 82f36d5ca15df18bdc8ebbbd868d3394db38e603
> src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164
>
> Diff: https://reviews.apache.org/r/34020/diff/
>
>
> Testing
> -------
>
> [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test
>
> BUILD SUCCESSFUL
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34020: Squelch extraneous Stats logging to prevent
spamming scheduler startup log.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review93617
-----------------------------------------------------------
Master (d9c911a) is red with this patch.
./build-support/jenkins/build.sh
:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java:20: Wrong order for 'java.util.Map.Entry' import. Order should be: java, javax, scala, com, net, org. Each group should be separated by a single blank line.
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 46.946 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On July 30, 2015, 5:36 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 5:36 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names.
>
> Stat names will be unchanged as a result of this.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893
> src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478
>
> Diff: https://reviews.apache.org/r/34020/diff/
>
>
> Testing
> -------
>
> [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test
>
> BUILD SUCCESSFUL
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34020: Squelch extraneous Stats logging to prevent
spamming scheduler startup log.
Posted by Joe Smith <ya...@gmail.com>.
> On July 30, 2015, 5:22 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 243
> > <https://reviews.apache.org/r/34020/diff/5/?file=1025333#file1025333line243>
> >
> > Oh wow sorry for the poor guidance, this actually is not something we should do. In the last pass i convinced myself that this was using the local logger, but reaching out to Stats' logger and changing it is not good behavior.
> >
> > I'd happily wait for the fork and live with the log noise rather than go this direction.
>
> Joe Smith wrote:
> Aha, gotcha- no worries, I'll update the ticket and discard this.
>
> Joe Smith wrote:
> Well- to make sure I learn to fish- this is because we're then modifying Stats, which typically doesn't happen from another class? (And its normally done [via configuration](http://docs.oracle.com/javase/8/docs/api/java/util/logging/LogManager.html) instead?)
>
> Bill Farner wrote:
> Yeah, it's just kind of sneaky. Even if the operator tries to configure the logging system, or we try to adjust the log level on the fly, this code undermines that. That might be okay for the logging done today, but who knows about tomorrow.
Yep, gotcha- thanks!
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review93682
-----------------------------------------------------------
On July 30, 2015, 5:14 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 5:14 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names.
>
> Stat names will be unchanged as a result of this.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893
> src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478
>
> Diff: https://reviews.apache.org/r/34020/diff/
>
>
> Testing
> -------
>
> $ ./gradlew build -Pq
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34020: Squelch extraneous Stats logging to prevent
spamming scheduler startup log.
Posted by Joe Smith <ya...@gmail.com>.
> On July 30, 2015, 5:22 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 243
> > <https://reviews.apache.org/r/34020/diff/5/?file=1025333#file1025333line243>
> >
> > Oh wow sorry for the poor guidance, this actually is not something we should do. In the last pass i convinced myself that this was using the local logger, but reaching out to Stats' logger and changing it is not good behavior.
> >
> > I'd happily wait for the fork and live with the log noise rather than go this direction.
>
> Joe Smith wrote:
> Aha, gotcha- no worries, I'll update the ticket and discard this.
Well- to make sure I learn to fish- this is because we're then modifying Stats, which typically doesn't happen from another class? (And its normally done [via configuration](http://docs.oracle.com/javase/8/docs/api/java/util/logging/LogManager.html) instead?)
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review93682
-----------------------------------------------------------
On July 30, 2015, 5:14 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 5:14 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names.
>
> Stat names will be unchanged as a result of this.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893
> src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478
>
> Diff: https://reviews.apache.org/r/34020/diff/
>
>
> Testing
> -------
>
> $ ./gradlew build -Pq
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34020: Squelch extraneous Stats logging to prevent
spamming scheduler startup log.
Posted by Joe Smith <ya...@gmail.com>.
> On July 30, 2015, 5:22 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 243
> > <https://reviews.apache.org/r/34020/diff/5/?file=1025333#file1025333line243>
> >
> > Oh wow sorry for the poor guidance, this actually is not something we should do. In the last pass i convinced myself that this was using the local logger, but reaching out to Stats' logger and changing it is not good behavior.
> >
> > I'd happily wait for the fork and live with the log noise rather than go this direction.
Aha, gotcha- no worries, I'll update the ticket and discard this.
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review93682
-----------------------------------------------------------
On July 30, 2015, 5:14 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 5:14 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names.
>
> Stat names will be unchanged as a result of this.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893
> src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478
>
> Diff: https://reviews.apache.org/r/34020/diff/
>
>
> Testing
> -------
>
> $ ./gradlew build -Pq
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34020: Squelch extraneous Stats logging to prevent
spamming scheduler startup log.
Posted by Bill Farner <wf...@apache.org>.
> On July 31, 2015, 12:22 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 243
> > <https://reviews.apache.org/r/34020/diff/5/?file=1025333#file1025333line243>
> >
> > Oh wow sorry for the poor guidance, this actually is not something we should do. In the last pass i convinced myself that this was using the local logger, but reaching out to Stats' logger and changing it is not good behavior.
> >
> > I'd happily wait for the fork and live with the log noise rather than go this direction.
>
> Joe Smith wrote:
> Aha, gotcha- no worries, I'll update the ticket and discard this.
>
> Joe Smith wrote:
> Well- to make sure I learn to fish- this is because we're then modifying Stats, which typically doesn't happen from another class? (And its normally done [via configuration](http://docs.oracle.com/javase/8/docs/api/java/util/logging/LogManager.html) instead?)
Yeah, it's just kind of sneaky. Even if the operator tries to configure the logging system, or we try to adjust the log level on the fly, this code undermines that. That might be okay for the logging done today, but who knows about tomorrow.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review93682
-----------------------------------------------------------
On July 31, 2015, 12:14 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 12:14 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names.
>
> Stat names will be unchanged as a result of this.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893
> src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478
>
> Diff: https://reviews.apache.org/r/34020/diff/
>
>
> Testing
> -------
>
> $ ./gradlew build -Pq
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34020: Squelch extraneous Stats logging to prevent
spamming scheduler startup log.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review93682
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/TaskVars.java (line 243)
<https://reviews.apache.org/r/34020/#comment148097>
Oh wow sorry for the poor guidance, this actually is not something we should do. In the last pass i convinced myself that this was using the local logger, but reaching out to Stats' logger and changing it is not good behavior.
I'd happily wait for the fork and live with the log noise rather than go this direction.
- Bill Farner
On July 31, 2015, 12:14 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 12:14 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names.
>
> Stat names will be unchanged as a result of this.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893
> src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478
>
> Diff: https://reviews.apache.org/r/34020/diff/
>
>
> Testing
> -------
>
> $ ./gradlew build -Pq
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34020: Squelch extraneous Stats logging to prevent
spamming scheduler startup log.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review93686
-----------------------------------------------------------
Master (d327773) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On July 31, 2015, 12:14 a.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 12:14 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names.
>
> Stat names will be unchanged as a result of this.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893
> src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478
>
> Diff: https://reviews.apache.org/r/34020/diff/
>
>
> Testing
> -------
>
> $ ./gradlew build -Pq
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34020: Squelch extraneous Stats logging to prevent
spamming scheduler startup log.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/
-----------------------------------------------------------
(Updated July 30, 2015, 5:14 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Updated with a TODO to remove, happy to update if that doesn't seem clear
Bugs: AURORA-1282
https://issues.apache.org/jira/browse/AURORA-1282
Repository: aurora
Description
-------
Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names.
Stat names will be unchanged as a result of this.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893
src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478
Diff: https://reviews.apache.org/r/34020/diff/
Testing
-------
$ ./gradlew build -Pq
Thanks,
Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent
spamming scheduler startup log.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review93656
-----------------------------------------------------------
Master (d327773) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On July 30, 2015, 10:02 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 10:02 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names.
>
> Stat names will be unchanged as a result of this.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893
> src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478
>
> Diff: https://reviews.apache.org/r/34020/diff/
>
>
> Testing
> -------
>
> $ ./gradlew build -Pq
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34020: Squelch extraneous Stats logging to prevent
spamming scheduler startup log.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review93665
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/TaskVars.java (line 255)
<https://reviews.apache.org/r/34020/#comment148076>
This is not generally the right thing to do, as jdk logging allows you to configure this externally with configuration. However, i don't see a great alternative that allows us to pick a sane default for other users of the software. Please at least leave a TODO here and in the other file indicating why you're doing this.
- Bill Farner
On July 30, 2015, 10:02 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 10:02 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names.
>
> Stat names will be unchanged as a result of this.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893
> src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478
>
> Diff: https://reviews.apache.org/r/34020/diff/
>
>
> Testing
> -------
>
> $ ./gradlew build -Pq
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34020: Squelch extraneous Stats logging to prevent
spamming scheduler startup log.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/
-----------------------------------------------------------
(Updated July 30, 2015, 3:02 p.m.)
Review request for Aurora and Bill Farner.
Bugs: AURORA-1282
https://issues.apache.org/jira/browse/AURORA-1282
Repository: aurora
Description
-------
Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names.
Stat names will be unchanged as a result of this.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893
src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478
Diff: https://reviews.apache.org/r/34020/diff/
Testing (updated)
-------
$ ./gradlew build -Pq
Thanks,
Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent
spamming scheduler startup log.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/
-----------------------------------------------------------
(Updated July 30, 2015, 3:02 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Moved the stats change to the inner class (not sure if this is ~good or not, feedback welcome).
Bugs: AURORA-1282
https://issues.apache.org/jira/browse/AURORA-1282
Repository: aurora
Description
-------
Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names.
Stat names will be unchanged as a result of this.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893
src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478
Diff: https://reviews.apache.org/r/34020/diff/
Testing
-------
[tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test
BUILD SUCCESSFUL
Thanks,
Joe Smith
Re: Review Request 34020: Squelch extraneous Stats logging to prevent
spamming scheduler startup log.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/
-----------------------------------------------------------
(Updated July 30, 2015, 10:36 a.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Stephan Erb's additional catch
Summary (updated)
-----------------
Squelch extraneous Stats logging to prevent spamming scheduler startup log.
Bugs: AURORA-1282
https://issues.apache.org/jira/browse/AURORA-1282
Repository: aurora
Description (updated)
-------
Change the log level for Stats- this will prevent spurious log messages for domain-acceptable stats names.
Stat names will be unchanged as a result of this.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/TaskVars.java 54d893e4bf02d4a49b445a0894b015e62deaf893
src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478
Diff: https://reviews.apache.org/r/34020/diff/
Testing
-------
[tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test
BUILD SUCCESSFUL
Thanks,
Joe Smith
Re: Review Request 34020: Normalize SLA stat names
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/
-----------------------------------------------------------
(Updated July 30, 2015, 10:32 a.m.)
Review request for Aurora and Bill Farner.
Bugs: AURORA-1282
https://issues.apache.org/jira/browse/AURORA-1282
Repository: aurora
Description
-------
Normalize SLA stat names ahead of time- this will prevent spurious log messages.
Stat names will be unchanged as a result of this.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java a47da095de7c602fca8841e7f17a9dc4f78d0478
Diff: https://reviews.apache.org/r/34020/diff/
Testing
-------
[tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test
BUILD SUCCESSFUL
Thanks,
Joe Smith
Re: Review Request 34020: Normalize SLA stat names
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/
-----------------------------------------------------------
(Updated June 12, 2015, 4:18 p.m.)
Review request for Aurora and Bill Farner.
Bugs: AURORA-1282
https://issues.apache.org/jira/browse/AURORA-1282
Repository: aurora
Description (updated)
-------
Normalize SLA stat names ahead of time- this will prevent spurious log messages.
Stat names will be unchanged as a result of this.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 82f36d5ca15df18bdc8ebbbd868d3394db38e603
src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164
Diff: https://reviews.apache.org/r/34020/diff/
Testing
-------
[tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test
BUILD SUCCESSFUL
Thanks,
Joe Smith
Re: Review Request 34020: Normalize SLA stat names
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review83302
-----------------------------------------------------------
As Maxim pointed out on the ticket, there is a compatibility concern that should be addressed. If you don't mind, i'd like to conclude that discussion before reviewing.
- Bill Farner
On May 9, 2015, 9:54 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
>
> (Updated May 9, 2015, 9:54 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Normalize SLA stat names
>
> This is going to change these metrics from `sla_role/env/job_job_uptime_50.00_sec` to `sla_role_env_job_job_uptime_50_00_sec`
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 82f36d5ca15df18bdc8ebbbd868d3394db38e603
> src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164
>
> Diff: https://reviews.apache.org/r/34020/diff/
>
>
> Testing
> -------
>
> [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test
>
> BUILD SUCCESSFUL
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 34020: Normalize SLA stat names
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review83167
-----------------------------------------------------------
Ship it!
Master (1c09d58) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 9, 2015, 9:54 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
>
> (Updated May 9, 2015, 9:54 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Normalize SLA stat names
>
> This is going to change these metrics from `sla_role/env/job_job_uptime_50.00_sec` to `sla_role_env_job_job_uptime_50_00_sec`
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 82f36d5ca15df18bdc8ebbbd868d3394db38e603
> src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java cb98834e925793fc116814371548a30470830164
>
> Diff: https://reviews.apache.org/r/34020/diff/
>
>
> Testing
> -------
>
> [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test
>
> BUILD SUCCESSFUL
>
>
> Thanks,
>
> Joe Smith
>
>