You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/01/19 21:44:00 UTC
[GitHub] [incubator-yunikorn-k8shim] ayubpathan opened a new pull request #221: [YUNIKORN-508] Fixing the log collection path for upstream runs
ayubpathan opened a new pull request #221:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/221
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #221: [YUNIKORN-508] Fixing the log collection path for upstream runs
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #221:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #221: [YUNIKORN-508] Fixing the log collection path for upstream runs
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #221:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/221#issuecomment-763275020
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/221?src=pr&el=h1) Report
> Merging [#221](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/221?src=pr&el=desc) (bdb24ee) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/eb888dfcf3b74ce248f2ed3b92ae5bddaf6caf5a?el=desc) (eb888df) will **decrease** coverage by `0.34%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #221 +/- ##
==========================================
- Coverage 57.78% 57.43% -0.35%
==========================================
Files 32 32
Lines 2859 2859
==========================================
- Hits 1652 1642 -10
- Misses 1138 1147 +9
- Partials 69 70 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/221/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `66.97% <0.00%> (-4.66%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/221?src=pr&el=footer). Last update [eb888df...bdb24ee](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #221: [YUNIKORN-508] Fixing the log collection path for upstream runs
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #221:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/221#discussion_r560600807
##########
File path: test/e2e/framework/configmanager/config.go
##########
@@ -61,6 +61,6 @@ func (c *YuniKornTestConfigType) ParseFlags() {
"External Port of YuniKorn service")
flag.StringVar(&c.YkScheme, "yk-scheme", DefaultYuniKornScheme,
"Scheme of YuniKron Service")
- flag.StringVar(&c.LogDir, "log-dir", "/yunikorn-qe/test-results/target/failsafe-reports",
+ flag.StringVar(&c.LogDir, "log-dir", "/tmp/test-results/target/failsafe-reports",
Review comment:
instead of hard coding to /tmp, is it better to create a tmp dir with https://yourbasic.org/golang/temporary-file-directory for the job?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on pull request #221: [YUNIKORN-508] Fixing the log collection path for upstream runs
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #221:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/221#issuecomment-969831507
superseded by PR #329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org