[GitHub] [incubator-kvrocks] torwig commented on a diff in pull request #1171: add config about logcleaner

[GitBox <gi...@apache.org>]

torwig commented on code in PR #1171:
URL: https://github.com/apache/incubator-kvrocks/pull/1171#discussion_r1043546674


##########
kvrocks.conf:
##########
@@ -96,6 +96,15 @@ dir /tmp/kvrocks
 # We also can send logs to stdout/stderr is as simple as:
 #
 log-dir stdout
+# log-dir log
+
+# To enable the log cleaner. if set yes , glog will check if there are
+# overdue logs whenever a flush is performed
+enablelogcleaner yes
+
+# INFO level log file whose last modified time is greater than logcleanerday
+# will be unlinked
+logcleanerday 0

Review Comment:
   Could you please also mention in the comment what is the default value for `logcleanerday` and set it instead of 0? By the way, what will happen if the value of this setting is `0`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org