[jira] [Commented] (HIVE-7519) Refactor QTestUtil to remove its duplication with QFileClient for qtest setup and teardown

["Szehon Ho (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-7519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075164#comment-14075164 ] 

Szehon Ho commented on HIVE-7519:
---------------------------------

Looks like a good idea.  I left some comments and questions on the rb, thanks.

> Refactor QTestUtil to remove its duplication with QFileClient for qtest setup and teardown 
> -------------------------------------------------------------------------------------------
>
>                 Key: HIVE-7519
>                 URL: https://issues.apache.org/jira/browse/HIVE-7519
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Ashish Kumar Singh
>            Assignee: Ashish Kumar Singh
>         Attachments: HIVE-7519.patch
>
>
> QTestUtil hard codes creation and dropping of source tables for qtests. QFileClient does the same thing but in a better way, uses q_test_init.sql and q_test_cleanup.sql scripts. As QTestUtil is growing quite large it makes sense to refactor it to use QFileClient's approach. This will also remove duplication of code addressing same purpose.



--
This message was sent by Atlassian JIRA
(v6.2#6252)