You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by da...@apache.org on 2012/12/13 18:27:55 UTC
svn commit: r1421397 -
/subversion/site/publish/docs/community-guide/conventions.part.html
Author: danielsh
Date: Thu Dec 13 17:27:54 2012
New Revision: 1421397
URL: http://svn.apache.org/viewvc?rev=1421397&view=rev
Log:
* docs/community-guide/conventions.part.html
(#crediting): Update for r1421383.
Inspired by: rhuijben
Modified:
subversion/site/publish/docs/community-guide/conventions.part.html
Modified: subversion/site/publish/docs/community-guide/conventions.part.html
URL: http://svn.apache.org/viewvc/subversion/site/publish/docs/community-guide/conventions.part.html?rev=1421397&r1=1421396&r2=1421397&view=diff
==============================================================================
--- subversion/site/publish/docs/community-guide/conventions.part.html (original)
+++ subversion/site/publish/docs/community-guide/conventions.part.html Thu Dec 13 17:27:54 2012
@@ -1087,7 +1087,7 @@ change.</p>
<p>If someone found the bug or pointed out the problem, but didn't
write the patch, indicate their contribution with
-"Found by: ":</p>
+"Found by: " (or "Reported by: "):</p>
<pre>
Fix issue #1729: Don't crash because of a missing file.
@@ -1109,6 +1109,19 @@ indicate their contribution with "Sugges
Suggested by: dlr
</pre>
+<p>If someone test-drove a patch, use "Tested by: ":</p>
+
+<pre>
+ Fix issue #23: random crashes on FreeBSD 3.14.
+
+ Tested by: Old Platformer
+ (I couldn't reproduce the problem, but Old hasn't seen any crashes since
+ he applied the patch.)
+
+ * subversion/libsvn_fs_sieve/obliterate.c
+ (cover_up): Account for sieve(2) returning 6.
+</pre>
+
<p>If someone reviewed the change, use "Review by: "
(or "Reviewed by: " if you prefer):</p>
@@ -1165,6 +1178,7 @@ that the spacing is optional and not nec
Suggested by:
Found by:
Review by:
+ Tested by:
</pre>
<p>are the only officially-supported crediting fields (where
@@ -1172,7 +1186,7 @@ that the spacing is optional and not nec
used in Subversion log messages. Future fields will probably be of
the form "VERB by: ", and from time to time someone may use
a field that sounds official but really is not — for
-example, there are a few instances of "Reported by: ".
+example, there are a few instances of "Inspired by: ".
These are okay, but try to use an official field, or a parenthetical
aside, in preference to creating your own. Also, don't use
"Reported by: " when the reporter is already recorded in an