You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Liam Sargent <li...@gmail.com> on 2018/02/01 20:55:29 UTC

Issues with Codahale/Dropwizard metrics dependencies

Hello Sentry Folks,

I am working on patching some bugs in Sentry, and I am having a hard time
getting my tests to run properly. It seems every time I run tests, I am
running into dependency-related conflicts concerning a particular metrics
package that supplies JVM statistics called "metrics", with several
packages pointing to a version called com.codahale.metrics, and several
pointing to io.dropwizard.metrics.

I believe these are both referencing different versions of the same
packages, but a namespace change occurred somewhere along the 3.1 release
that is confusing maven and thus, myself.

Does anyone have a definitive answer of which version of metrics should be
on the classpath for test execution and development? Many Hadoop
dependencies point at 3.2.2 (dropwizard), but our main pom.xml points at
3.0.2 (codahale)


Is there any reason we are using this version? Could we safely bump the
version to dropwizard 3.2.2?

Cheers,
Liam Sargent

Re: Issues with Codahale/Dropwizard metrics dependencies

Posted by Alexander Kolbasov <ak...@cloudera.com>.
Hi Liam,

I don’t think there is a particular reason other then historical development. I think we should just align with whatever version is used by majority of other components or just use the latest version. I don’t see any reason to run with old version.

- Alex

> On Feb 1, 2018, at 12:55 PM, Liam Sargent <li...@gmail.com> wrote:
> 
> Hello Sentry Folks,
> 
> I am working on patching some bugs in Sentry, and I am having a hard time
> getting my tests to run properly. It seems every time I run tests, I am
> running into dependency-related conflicts concerning a particular metrics
> package that supplies JVM statistics called "metrics", with several
> packages pointing to a version called com.codahale.metrics, and several
> pointing to io.dropwizard.metrics.
> 
> I believe these are both referencing different versions of the same
> packages, but a namespace change occurred somewhere along the 3.1 release
> that is confusing maven and thus, myself.
> 
> Does anyone have a definitive answer of which version of metrics should be
> on the classpath for test execution and development? Many Hadoop
> dependencies point at 3.2.2 (dropwizard), but our main pom.xml points at
> 3.0.2 (codahale)
> 
> 
> Is there any reason we are using this version? Could we safely bump the
> version to dropwizard 3.2.2?
> 
> Cheers,
> Liam Sargent