You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/18 10:08:53 UTC

[GitHub] [airflow] eladkal commented on a change in pull request #8429: [AIRFLOW-5156] Added auth type to HttpHook

eladkal commented on a change in pull request #8429: [AIRFLOW-5156] Added auth type to HttpHook
URL: https://github.com/apache/airflow/pull/8429#discussion_r410677930
 
 

 ##########
 File path: airflow/providers/http/hooks/http.py
 ##########
 @@ -27,20 +28,28 @@ class HttpHook(BaseHook):
     """
     Interact with HTTP servers.
 
+    :param method: the API method to be called
+    :type method: str
     :param http_conn_id: connection that has the base API url i.e https://www.google.com/
         and optional authentication credentials. Default headers can also be specified in
         the Extra field in json format.
     :type http_conn_id: str
-    :param method: the API method to be called
-    :type method: str
+    :param auth_type: the API method to be called
+    :type method: AuthBase of python requests lib
 
 Review comment:
   It should be 
   `    :type auth_type: AuthBase of python requests lib`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services