[GitHub] [helix] jiajunwang commented on a change in pull request #1237: Add error message of instance check to stoppable API response

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #1237:
URL: https://github.com/apache/helix/pull/1237#discussion_r472446728



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java
##########
@@ -213,7 +219,12 @@ public StoppableCheck getInstanceStoppableCheck(String clusterId, String instanc
           instancesForNextCheck.add(instance);
         }
       } catch (InterruptedException | ExecutionException e) {
-        LOG.error("Failed to get StoppableChecks in parallel. Instance: {}", instance, e);
+        LOG.warn("Failed to get StoppableChecks in parallel. Instance: {}. Caused by {}", instance,

Review comment:
       Why it is a warning now?

##########
File path: helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
##########
@@ -261,7 +261,9 @@ public static boolean isInstanceStable(HelixDataAccessor dataAccessor, String in
       throw new HelixException("Missing cluster config!");
     }
     if (!clusterConfig.isPersistIntermediateAssignment()) {
-      throw new HelixException("isInstanceStable needs persist assignment on!");
+      throw new HelixException(String.format(
+          "Instance stability check needs persist assignment cluster config turned on: %s = true",

Review comment:
       I find this may be misleading. Can we change it to, "Persist assignment (%s) is not turned on in the Cluster Config. This is required to enable instance stability check."




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org