You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Ersin Er (JIRA)" <di...@incubator.apache.org> on 2005/09/14 15:42:54 UTC
[jira] Created: (DIRLDAP-53) "LDAP ACIItem" Parser Implementation
"LDAP ACIItem" Parser Implementation
------------------------------------
Key: DIRLDAP-53
URL: http://issues.apache.org/jira/browse/DIRLDAP-53
Project: Directory LDAP
Type: New Feature
Components: Common
Versions: 0.9.3
Reporter: Ersin Er
Priority: Minor
An implementation of ACIItem, ported from X.501 to LDAP, parser is provided as a patch attached with this issue.
The implementation includes:
- an almost complete "LDAP ACIItem" Antlr grammar
- a wrapper around the Antlr generated classes
- two auxilary classes for parser/lexer pair reusability
- a test class
- and a maven configuration update
TODO:
- Good test coverage
- Model integration via actions
- Cleanup
ACI is a tough subject and this parser is no exception. This is somewhat a big grammar that needs extensive testing which is missing now. The current grammar does not integrate with ACIItem API implemented by Trustin, because we need to discuss some issues about porting X.501 ACIItem to LDAP and about string representation of some components. After we agree on a robust spec, I'll update the grammar to fully comply with "our ACIItem spec" (Trustin may also need to update his stuff). One more step will be integrating with ACIItem API which will be a one hour task with Trustin's super clear implementation (thanks Trustin!).
I'll further discuss the issue on the mailing list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIRLDAP-53) "LDAP ACIItem" Parser Implementation
Posted by "Trustin Lee (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRLDAP-53?page=comments#action_12329305 ]
Trustin Lee commented on DIRLDAP-53:
------------------------------------
Hey, thanks for your generous praise. :)
> "LDAP ACIItem" Parser Implementation
> ------------------------------------
>
> Key: DIRLDAP-53
> URL: http://issues.apache.org/jira/browse/DIRLDAP-53
> Project: Directory LDAP
> Type: New Feature
> Components: Common
> Versions: 0.9.3
> Reporter: Ersin Er
> Priority: Minor
> Attachments: ACIItemParser_01.patch
>
> An implementation of ACIItem, ported from X.501 to LDAP, parser is provided as a patch attached with this issue.
> The implementation includes:
> - an almost complete "LDAP ACIItem" Antlr grammar
> - a wrapper around the Antlr generated classes
> - two auxilary classes for parser/lexer pair reusability
> - a test class
> - and a maven configuration update
> TODO:
> - Good test coverage
> - Model integration via actions
> - Cleanup
> ACI is a tough subject and this parser is no exception. This is somewhat a big grammar that needs extensive testing which is missing now. The current grammar does not integrate with ACIItem API implemented by Trustin, because we need to discuss some issues about porting X.501 ACIItem to LDAP and about string representation of some components. After we agree on a robust spec, I'll update the grammar to fully comply with "our ACIItem spec" (Trustin may also need to update his stuff). One more step will be integrating with ACIItem API which will be a one hour task with Trustin's super clear implementation (thanks Trustin!).
> I'll further discuss the issue on the mailing list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIRLDAP-53) "LDAP ACIItem" Parser Implementation
Posted by "Alex Karasulu (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRLDAP-53?page=comments#action_12329311 ]
Alex Karasulu commented on DIRLDAP-53:
--------------------------------------
Dude this is an awesome patch. I cannot express how difficult the ASN.1 interpretation of the ACIItem must have been into an antlr LL(1) grammar. This is a great job and a great patch as I can see after reviewing it. I will apply it now.
Thank you for being so thorough.
> "LDAP ACIItem" Parser Implementation
> ------------------------------------
>
> Key: DIRLDAP-53
> URL: http://issues.apache.org/jira/browse/DIRLDAP-53
> Project: Directory LDAP
> Type: New Feature
> Components: Common
> Versions: 0.9.3
> Reporter: Ersin Er
> Priority: Minor
> Attachments: ACIItemParser_01.patch
>
> An implementation of ACIItem, ported from X.501 to LDAP, parser is provided as a patch attached with this issue.
> The implementation includes:
> - an almost complete "LDAP ACIItem" Antlr grammar
> - a wrapper around the Antlr generated classes
> - two auxilary classes for parser/lexer pair reusability
> - a test class
> - and a maven configuration update
> TODO:
> - Good test coverage
> - Model integration via actions
> - Cleanup
> ACI is a tough subject and this parser is no exception. This is somewhat a big grammar that needs extensive testing which is missing now. The current grammar does not integrate with ACIItem API implemented by Trustin, because we need to discuss some issues about porting X.501 ACIItem to LDAP and about string representation of some components. After we agree on a robust spec, I'll update the grammar to fully comply with "our ACIItem spec" (Trustin may also need to update his stuff). One more step will be integrating with ACIItem API which will be a one hour task with Trustin's super clear implementation (thanks Trustin!).
> I'll further discuss the issue on the mailing list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIRLDAP-53) "LDAP ACIItem" Parser Implementation
Posted by "Ersin Er (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRLDAP-53?page=comments#action_12329512 ]
Ersin Er commented on DIRLDAP-53:
---------------------------------
OK, forget about patch #02. I'm working on next phase and patch #03 will include #02 also.
> "LDAP ACIItem" Parser Implementation
> ------------------------------------
>
> Key: DIRLDAP-53
> URL: http://issues.apache.org/jira/browse/DIRLDAP-53
> Project: Directory LDAP
> Type: New Feature
> Components: Common
> Versions: 0.9.3
> Reporter: Ersin Er
> Priority: Minor
> Fix For: 0.9.3
> Attachments: ACIItemParser_01.patch, ACIItemParser_02.patch
>
> An implementation of ACIItem, ported from X.501 to LDAP, parser is provided as a patch attached with this issue.
> The implementation includes:
> - an almost complete "LDAP ACIItem" Antlr grammar
> - a wrapper around the Antlr generated classes
> - two auxilary classes for parser/lexer pair reusability
> - a test class
> - and a maven configuration update
> TODO:
> - Good test coverage
> - Model integration via actions
> - Cleanup
> ACI is a tough subject and this parser is no exception. This is somewhat a big grammar that needs extensive testing which is missing now. The current grammar does not integrate with ACIItem API implemented by Trustin, because we need to discuss some issues about porting X.501 ACIItem to LDAP and about string representation of some components. After we agree on a robust spec, I'll update the grammar to fully comply with "our ACIItem spec" (Trustin may also need to update his stuff). One more step will be integrating with ACIItem API which will be a one hour task with Trustin's super clear implementation (thanks Trustin!).
> I'll further discuss the issue on the mailing list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DIRLDAP-53) "LDAP ACIItem" Parser Implementation
Posted by "Ersin Er (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRLDAP-53?page=all ]
Ersin Er updated DIRLDAP-53:
----------------------------
Attachment: ACIItemParser_02.patch
> "LDAP ACIItem" Parser Implementation
> ------------------------------------
>
> Key: DIRLDAP-53
> URL: http://issues.apache.org/jira/browse/DIRLDAP-53
> Project: Directory LDAP
> Type: New Feature
> Components: Common
> Versions: 0.9.3
> Reporter: Ersin Er
> Priority: Minor
> Fix For: 0.9.3
> Attachments: ACIItemParser_01.patch, ACIItemParser_02.patch
>
> An implementation of ACIItem, ported from X.501 to LDAP, parser is provided as a patch attached with this issue.
> The implementation includes:
> - an almost complete "LDAP ACIItem" Antlr grammar
> - a wrapper around the Antlr generated classes
> - two auxilary classes for parser/lexer pair reusability
> - a test class
> - and a maven configuration update
> TODO:
> - Good test coverage
> - Model integration via actions
> - Cleanup
> ACI is a tough subject and this parser is no exception. This is somewhat a big grammar that needs extensive testing which is missing now. The current grammar does not integrate with ACIItem API implemented by Trustin, because we need to discuss some issues about porting X.501 ACIItem to LDAP and about string representation of some components. After we agree on a robust spec, I'll update the grammar to fully comply with "our ACIItem spec" (Trustin may also need to update his stuff). One more step will be integrating with ACIItem API which will be a one hour task with Trustin's super clear implementation (thanks Trustin!).
> I'll further discuss the issue on the mailing list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIRLDAP-53) "LDAP ACIItem" Parser Implementation
Posted by "Alex Karasulu (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRLDAP-53?page=comments#action_12329558 ]
Alex Karasulu commented on DIRLDAP-53:
--------------------------------------
Ok I just applied it but I will revert my working directory. I will ignore patch #2. In fact let me delete it. Also perhaps you can submit the next patch in a new issue. We can link that new issue to this one. WDYT?
> "LDAP ACIItem" Parser Implementation
> ------------------------------------
>
> Key: DIRLDAP-53
> URL: http://issues.apache.org/jira/browse/DIRLDAP-53
> Project: Directory LDAP
> Type: New Feature
> Components: Common
> Versions: 0.9.3
> Reporter: Ersin Er
> Priority: Minor
> Fix For: 0.9.3
> Attachments: ACIItemParser_01.patch
>
> An implementation of ACIItem, ported from X.501 to LDAP, parser is provided as a patch attached with this issue.
> The implementation includes:
> - an almost complete "LDAP ACIItem" Antlr grammar
> - a wrapper around the Antlr generated classes
> - two auxilary classes for parser/lexer pair reusability
> - a test class
> - and a maven configuration update
> TODO:
> - Good test coverage
> - Model integration via actions
> - Cleanup
> ACI is a tough subject and this parser is no exception. This is somewhat a big grammar that needs extensive testing which is missing now. The current grammar does not integrate with ACIItem API implemented by Trustin, because we need to discuss some issues about porting X.501 ACIItem to LDAP and about string representation of some components. After we agree on a robust spec, I'll update the grammar to fully comply with "our ACIItem spec" (Trustin may also need to update his stuff). One more step will be integrating with ACIItem API which will be a one hour task with Trustin's super clear implementation (thanks Trustin!).
> I'll further discuss the issue on the mailing list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DIRLDAP-53) "LDAP ACIItem" Parser Implementation
Posted by "Alex Karasulu (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRLDAP-53?page=all ]
Alex Karasulu resolved DIRLDAP-53:
----------------------------------
Fix Version: 0.9.3
Resolution: Fixed
Committed patch on revision 280902 here:
http://svn.apache.org/viewcvs.cgi?view=rev&rev=280902
> "LDAP ACIItem" Parser Implementation
> ------------------------------------
>
> Key: DIRLDAP-53
> URL: http://issues.apache.org/jira/browse/DIRLDAP-53
> Project: Directory LDAP
> Type: New Feature
> Components: Common
> Versions: 0.9.3
> Reporter: Ersin Er
> Priority: Minor
> Fix For: 0.9.3
> Attachments: ACIItemParser_01.patch
>
> An implementation of ACIItem, ported from X.501 to LDAP, parser is provided as a patch attached with this issue.
> The implementation includes:
> - an almost complete "LDAP ACIItem" Antlr grammar
> - a wrapper around the Antlr generated classes
> - two auxilary classes for parser/lexer pair reusability
> - a test class
> - and a maven configuration update
> TODO:
> - Good test coverage
> - Model integration via actions
> - Cleanup
> ACI is a tough subject and this parser is no exception. This is somewhat a big grammar that needs extensive testing which is missing now. The current grammar does not integrate with ACIItem API implemented by Trustin, because we need to discuss some issues about porting X.501 ACIItem to LDAP and about string representation of some components. After we agree on a robust spec, I'll update the grammar to fully comply with "our ACIItem spec" (Trustin may also need to update his stuff). One more step will be integrating with ACIItem API which will be a one hour task with Trustin's super clear implementation (thanks Trustin!).
> I'll further discuss the issue on the mailing list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DIRLDAP-53) "LDAP ACIItem" Parser Implementation
Posted by "Alex Karasulu (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRLDAP-53?page=all ]
Alex Karasulu updated DIRLDAP-53:
---------------------------------
Attachment: (was: ACIItemParser_02.patch)
> "LDAP ACIItem" Parser Implementation
> ------------------------------------
>
> Key: DIRLDAP-53
> URL: http://issues.apache.org/jira/browse/DIRLDAP-53
> Project: Directory LDAP
> Type: New Feature
> Components: Common
> Versions: 0.9.3
> Reporter: Ersin Er
> Priority: Minor
> Fix For: 0.9.3
> Attachments: ACIItemParser_01.patch
>
> An implementation of ACIItem, ported from X.501 to LDAP, parser is provided as a patch attached with this issue.
> The implementation includes:
> - an almost complete "LDAP ACIItem" Antlr grammar
> - a wrapper around the Antlr generated classes
> - two auxilary classes for parser/lexer pair reusability
> - a test class
> - and a maven configuration update
> TODO:
> - Good test coverage
> - Model integration via actions
> - Cleanup
> ACI is a tough subject and this parser is no exception. This is somewhat a big grammar that needs extensive testing which is missing now. The current grammar does not integrate with ACIItem API implemented by Trustin, because we need to discuss some issues about porting X.501 ACIItem to LDAP and about string representation of some components. After we agree on a robust spec, I'll update the grammar to fully comply with "our ACIItem spec" (Trustin may also need to update his stuff). One more step will be integrating with ACIItem API which will be a one hour task with Trustin's super clear implementation (thanks Trustin!).
> I'll further discuss the issue on the mailing list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (DIRSERVER-240) "LDAP ACIItem" Parser Implementation
Posted by "Ersin Er (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DIRSERVER-240?page=all ]
Ersin Er closed DIRSERVER-240:
------------------------------
Done.
> "LDAP ACIItem" Parser Implementation
> ------------------------------------
>
> Key: DIRSERVER-240
> URL: http://issues.apache.org/jira/browse/DIRSERVER-240
> Project: Directory ApacheDS
> Type: Bug
> Components: ldap
> Versions: pre-1.0
> Reporter: Ersin Er
> Priority: Minor
> Fix For: pre-1.0
> Attachments: ACIItemParser_01.patch
>
> An implementation of ACIItem, ported from X.501 to LDAP, parser is provided as a patch attached with this issue.
> The implementation includes:
> - an almost complete "LDAP ACIItem" Antlr grammar
> - a wrapper around the Antlr generated classes
> - two auxilary classes for parser/lexer pair reusability
> - a test class
> - and a maven configuration update
> TODO:
> - Good test coverage
> - Model integration via actions
> - Cleanup
> ACI is a tough subject and this parser is no exception. This is somewhat a big grammar that needs extensive testing which is missing now. The current grammar does not integrate with ACIItem API implemented by Trustin, because we need to discuss some issues about porting X.501 ACIItem to LDAP and about string representation of some components. After we agree on a robust spec, I'll update the grammar to fully comply with "our ACIItem spec" (Trustin may also need to update his stuff). One more step will be integrating with ACIItem API which will be a one hour task with Trustin's super clear implementation (thanks Trustin!).
> I'll further discuss the issue on the mailing list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DIRLDAP-53) "LDAP ACIItem" Parser Implementation
Posted by "Ersin Er (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRLDAP-53?page=all ]
Ersin Er updated DIRLDAP-53:
----------------------------
Attachment: ACIItemParser_01.patch
> "LDAP ACIItem" Parser Implementation
> ------------------------------------
>
> Key: DIRLDAP-53
> URL: http://issues.apache.org/jira/browse/DIRLDAP-53
> Project: Directory LDAP
> Type: New Feature
> Components: Common
> Versions: 0.9.3
> Reporter: Ersin Er
> Priority: Minor
> Attachments: ACIItemParser_01.patch
>
> An implementation of ACIItem, ported from X.501 to LDAP, parser is provided as a patch attached with this issue.
> The implementation includes:
> - an almost complete "LDAP ACIItem" Antlr grammar
> - a wrapper around the Antlr generated classes
> - two auxilary classes for parser/lexer pair reusability
> - a test class
> - and a maven configuration update
> TODO:
> - Good test coverage
> - Model integration via actions
> - Cleanup
> ACI is a tough subject and this parser is no exception. This is somewhat a big grammar that needs extensive testing which is missing now. The current grammar does not integrate with ACIItem API implemented by Trustin, because we need to discuss some issues about porting X.501 ACIItem to LDAP and about string representation of some components. After we agree on a robust spec, I'll update the grammar to fully comply with "our ACIItem spec" (Trustin may also need to update his stuff). One more step will be integrating with ACIItem API which will be a one hour task with Trustin's super clear implementation (thanks Trustin!).
> I'll further discuss the issue on the mailing list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DIRLDAP-53) "LDAP ACIItem" Parser Implementation
Posted by "Ersin Er (JIRA)" <di...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/DIRLDAP-53?page=comments#action_12329487 ]
Ersin Er commented on DIRLDAP-53:
---------------------------------
I've updated the grammar so that it reflects our ideas on needed ACIItem stuff and representation. It should be a complete and hopefully much less buggy grammar now. It does not include integration with model yet ( as i said before, it'll be the next patch ). I'm providing this patch as a milestone and for people to be able to see the progress. I'll do model integration next.
The updated ABNF grammar is available at:
http://docs.safehaus.org/display/APACHEDS/ABNF+syntax+for+LDAP+ACIItem
> "LDAP ACIItem" Parser Implementation
> ------------------------------------
>
> Key: DIRLDAP-53
> URL: http://issues.apache.org/jira/browse/DIRLDAP-53
> Project: Directory LDAP
> Type: New Feature
> Components: Common
> Versions: 0.9.3
> Reporter: Ersin Er
> Priority: Minor
> Fix For: 0.9.3
> Attachments: ACIItemParser_01.patch
>
> An implementation of ACIItem, ported from X.501 to LDAP, parser is provided as a patch attached with this issue.
> The implementation includes:
> - an almost complete "LDAP ACIItem" Antlr grammar
> - a wrapper around the Antlr generated classes
> - two auxilary classes for parser/lexer pair reusability
> - a test class
> - and a maven configuration update
> TODO:
> - Good test coverage
> - Model integration via actions
> - Cleanup
> ACI is a tough subject and this parser is no exception. This is somewhat a big grammar that needs extensive testing which is missing now. The current grammar does not integrate with ACIItem API implemented by Trustin, because we need to discuss some issues about porting X.501 ACIItem to LDAP and about string representation of some components. After we agree on a robust spec, I'll update the grammar to fully comply with "our ACIItem spec" (Trustin may also need to update his stuff). One more step will be integrating with ACIItem API which will be a one hour task with Trustin's super clear implementation (thanks Trustin!).
> I'll further discuss the issue on the mailing list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira