You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "shubhamraj-git (via GitHub)" <gi...@apache.org> on 2025/03/18 10:17:07 UTC
[PR] Add Dag Run options on Grid view page [airflow]
shubhamraj-git opened a new pull request, #47900:
URL: https://github.com/apache/airflow/pull/47900
closes: #47887
<img width="1728" alt="image" src="https://github.com/user-attachments/assets/d75b44e2-7e90-48ae-a9f4-3a493daf8ea6" />
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dag Run limit dropdown for Grid view page [airflow]
Posted by "shubhamraj-git (via GitHub)" <gi...@apache.org>.
shubhamraj-git commented on code in PR #47900:
URL: https://github.com/apache/airflow/pull/47900#discussion_r2010796807
##########
yarn.lock:
##########
Review Comment:
Ohh yes, let me remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dag Run limit dropdown for Grid view page [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #47900:
URL: https://github.com/apache/airflow/pull/47900#discussion_r2010792522
##########
yarn.lock:
##########
Review Comment:
Is this committed by accident?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dag Run limit dropdown for Grid view page [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #47900:
URL: https://github.com/apache/airflow/pull/47900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dag Run limit dropdown for Grid view page [airflow]
Posted by "shubhamraj-git (via GitHub)" <gi...@apache.org>.
shubhamraj-git commented on PR #47900:
URL: https://github.com/apache/airflow/pull/47900#issuecomment-2735862557
@bbovenzi Oh, I see! I misread the issue. You mean having a dynamic query parameter as a dropdown, which controls the number of runs displayed, similar to how it worked in the older version.
For the older UI, I see the control was on central level, which also affects the runs list and grid view, in the new UI implementation, the State filter on the runs list tab don't affect the grid view. Are we keeping both out of sync intentionally ? In that case we will have a run count dropdown just for grid view?
I can continue the changes in this PR itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dag Run limit dropdown for Grid view page [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #47900:
URL: https://github.com/apache/airflow/pull/47900#discussion_r2012214884
##########
airflow-core/src/airflow/ui/src/layouts/Details/PanelButtons.tsx:
##########
@@ -98,7 +115,33 @@ export const PanelButtons = ({ dagView, setDagView, ...rest }: Props) => {
</IconButton>
</ButtonGroup>
<Stack alignItems="flex-end" gap={1} mr={2}>
- <DagVersionSelect disabled={dagView !== "graph"} />
+ <HStack>
+ <DagVersionSelect disabled={dagView !== "graph"} />
+ {dagView === "grid" ? (
+ <Select.Root
+ bg="bg"
+ collection={displayRunOptions}
+ data-testid="display-dag-run-options"
+ onValueChange={handleLimitChange}
+ size="sm"
+ width="200px"
+ >
+ <Select.Trigger>
+ <Select.ValueText placeholder="Display Dag Run Limit" />
Review Comment:
```suggestion
<Select.ValueText placeholder="Total Dag Runs" />
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dag Run options on Grid view page [airflow]
Posted by "shubhamraj-git (via GitHub)" <gi...@apache.org>.
shubhamraj-git commented on PR #47900:
URL: https://github.com/apache/airflow/pull/47900#issuecomment-2735701639
@bbovenzi Oh, I see! I misread the issue. You mean having a dynamic query parameter as a dropdown, which controls the number of runs displayed, similar to how it worked in the older version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dag Run limit dropdown for Grid view page [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #47900:
URL: https://github.com/apache/airflow/pull/47900#issuecomment-2749194473
Testing I found a couple of glitches.
(1) The Grid is not displaying when I start a couple of runs. Might it be missing if some DAGs are just queued?
Can confirm. Might be an un-related bug. If any of the DAG runs is queued then the Grid is not displaying.
(2) Is a count is limit is seelcted, the clear button (x) is overlapping with the dropdown:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dag Run limit dropdown for Grid view page [airflow]
Posted by "shubhamraj-git (via GitHub)" <gi...@apache.org>.
shubhamraj-git closed pull request #47900: Add Dag Run limit dropdown for Grid view page
URL: https://github.com/apache/airflow/pull/47900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dag Run limit dropdown for Grid view page [airflow]
Posted by "shubhamraj-git (via GitHub)" <gi...@apache.org>.
shubhamraj-git commented on PR #47900:
URL: https://github.com/apache/airflow/pull/47900#issuecomment-2752186744
@jscheffl @bbovenzi Removed the placeholder and now it defaults to 10 and shows the same. Also removed the condition which displays it only on the grid view, since graph view have the list dag runs, which was always defaulting to 14, now instead it will be controlled via dropdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dag Run limit dropdown for Grid view page [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #47900:
URL: https://github.com/apache/airflow/pull/47900#discussion_r2012217241
##########
airflow-core/src/airflow/ui/src/layouts/Details/PanelButtons.tsx:
##########
@@ -98,7 +115,33 @@ export const PanelButtons = ({ dagView, setDagView, ...rest }: Props) => {
</IconButton>
</ButtonGroup>
<Stack alignItems="flex-end" gap={1} mr={2}>
- <DagVersionSelect disabled={dagView !== "graph"} />
+ <HStack>
+ <DagVersionSelect disabled={dagView !== "graph"} />
+ {dagView === "grid" ? (
+ <Select.Root
+ bg="bg"
+ collection={displayRunOptions}
+ data-testid="display-dag-run-options"
+ onValueChange={handleLimitChange}
+ size="sm"
+ width="200px"
+ >
+ <Select.Trigger>
+ <Select.ValueText placeholder="Display Dag Run Limit" />
Review Comment:
It would probably be better for us to have 10 selected by default instead of a placeholder or the clear button
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dag Run limit dropdown for Grid view page [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #47900:
URL: https://github.com/apache/airflow/pull/47900#issuecomment-2752683878
> @jscheffl does that queue issue happen in `main`?
@bbovenzi I tested yesterday on this PR... which was "close" to main. But I noticed it a couple of days ago.
But can re-produce on main. Itis simple: Navigate to a DAG with grid view. Turn scheduling of. Trigger the DAG but take care that the triogger does not activate scheduling again. See that there is a queued run. Press F5. Grid is empty.
Console reveals a HTTP 500.
Stack trace on server looks like:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dag Run options on Grid view page [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #47900:
URL: https://github.com/apache/airflow/pull/47900#issuecomment-2734004105
Sorry, I'm gonna close this one. We intentionally left the dagrunselect out of the grid view because it is redundant and only adds noise to the page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dag Run options on Grid view page [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi closed pull request #47900: Add Dag Run options on Grid view page
URL: https://github.com/apache/airflow/pull/47900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Dag Run limit dropdown for Grid view page [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #47900:
URL: https://github.com/apache/airflow/pull/47900#issuecomment-2751417291
@jscheffl does that queue issue happen in `main`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org