You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/08 09:56:14 UTC
[GitHub] [spark] MaxGekk opened a new pull request #29678: [SPARK-32815][ML][2.4] Fix LibSVM data source loading error on file paths with glob metacharacters
MaxGekk opened a new pull request #29678:
URL: https://github.com/apache/spark/pull/29678
### What changes were proposed in this pull request?
In the PR, I propose to fix an issue with LibSVM datasource when both of the following are true:
* no user specified schema
* some file paths contain escaped glob metacharacters, such as `[``]`, `{``}`, `*` etc.
The fix is a backport of https://github.com/apache/spark/pull/29675, and it is based on another bug fix for CSV/JSON datasources https://github.com/apache/spark/pull/29663.
### Why are the changes needed?
To fix the issue when the follow two queries try to read from paths `[abc]`:
```scala
spark.read.format("libsvm").load("""/tmp/\[abc\].csv""").show
```
but would end up hitting an exception:
```
Path does not exist: file:/private/var/folders/p3/dfs6mf655d7fnjrsjvldh0tc0000gn/T/spark-6ef0ae5e-ff9f-4c4f-9ff4-0db3ee1f6a82/[abc]/part-00000-26406ab9-4e56-45fd-a25a-491c18a05e76-c000.libsvm;
org.apache.spark.sql.AnalysisException: Path does not exist: file:/private/var/folders/p3/dfs6mf655d7fnjrsjvldh0tc0000gn/T/spark-6ef0ae5e-ff9f-4c4f-9ff4-0db3ee1f6a82/[abc]/part-00000-26406ab9-4e56-45fd-a25a-491c18a05e76-c000.libsvm;
at org.apache.spark.sql.execution.datasources.DataSource$.$anonfun$checkAndGlobPathIfNecessary$3(DataSource.scala:770)
at org.apache.spark.util.ThreadUtils$.$anonfun$parmap$2(ThreadUtils.scala:373)
at scala.concurrent.Future$.$anonfun$apply$1(Future.scala:659)
at scala.util.Success.$anonfun$map$1(Try.scala:255)
at scala.util.Success.map(Try.scala:213)
```
### Does this PR introduce _any_ user-facing change?
Yes
### How was this patch tested?
Added UT to `LibSVMRelationSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #29678: [SPARK-32815][ML][2.4] Fix LibSVM data source loading error on file paths with glob metacharacters
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #29678:
URL: https://github.com/apache/spark/pull/29678#discussion_r484797747
##########
File path: mllib/src/test/scala/org/apache/spark/ml/source/libsvm/LibSVMRelationSuite.scala
##########
@@ -184,4 +184,22 @@ class LibSVMRelationSuite extends SparkFunSuite with MLlibTestSparkContext {
spark.sql("DROP TABLE IF EXISTS libsvmTable")
}
}
+
+ test("SPARK-32815: Test LibSVM data source on file paths with glob metacharacters") {
+ val basePath = Utils.createDirectory(tempDir.getCanonicalPath, "globbing")
Review comment:
Here is the diff with the patch for 3.0 because withTempDir is not available in 2.4 here:
https://github.com/apache/spark/pull/29675/files#diff-ed6960b663c36ea39eee8c20aae09fb3R196
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29678: [SPARK-32815][ML][2.4] Fix LibSVM data source loading error on file paths with glob metacharacters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29678:
URL: https://github.com/apache/spark/pull/29678#issuecomment-688761564
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #29678: [SPARK-32815][ML][2.4] Fix LibSVM data source loading error on file paths with glob metacharacters
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #29678:
URL: https://github.com/apache/spark/pull/29678
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29678: [SPARK-32815][ML][2.4] Fix LibSVM data source loading error on file paths with glob metacharacters
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29678:
URL: https://github.com/apache/spark/pull/29678#issuecomment-688760823
**[Test build #128399 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128399/testReport)** for PR 29678 at commit [`f082f3b`](https://github.com/apache/spark/commit/f082f3bfd5697adf7651cdc0d3bd867940c9d68e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29678: [SPARK-32815][ML][2.4] Fix LibSVM data source loading error on file paths with glob metacharacters
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29678:
URL: https://github.com/apache/spark/pull/29678#issuecomment-688907252
thanks, merging to 2.4!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29678: [SPARK-32815][ML][2.4] Fix LibSVM data source loading error on file paths with glob metacharacters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29678:
URL: https://github.com/apache/spark/pull/29678#issuecomment-688761564
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29678: [SPARK-32815][ML][2.4] Fix LibSVM data source loading error on file paths with glob metacharacters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29678:
URL: https://github.com/apache/spark/pull/29678#issuecomment-688804859
**[Test build #128399 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128399/testReport)** for PR 29678 at commit [`f082f3b`](https://github.com/apache/spark/commit/f082f3bfd5697adf7651cdc0d3bd867940c9d68e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29678: [SPARK-32815][ML][2.4] Fix LibSVM data source loading error on file paths with glob metacharacters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29678:
URL: https://github.com/apache/spark/pull/29678#issuecomment-688805131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29678: [SPARK-32815][ML][2.4] Fix LibSVM data source loading error on file paths with glob metacharacters
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29678:
URL: https://github.com/apache/spark/pull/29678#issuecomment-688805131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29678: [SPARK-32815][ML][2.4] Fix LibSVM data source loading error on file paths with glob metacharacters
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29678:
URL: https://github.com/apache/spark/pull/29678#issuecomment-688760823
**[Test build #128399 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128399/testReport)** for PR 29678 at commit [`f082f3b`](https://github.com/apache/spark/commit/f082f3bfd5697adf7651cdc0d3bd867940c9d68e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org