You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by GitBox <gi...@apache.org> on 2020/10/23 05:58:38 UTC

[GitHub] [gora] podorvanova opened a new pull request #226: GORA-667 Revert GORA-271 changes in hbase-store 

podorvanova opened a new pull request #226:
URL: https://github.com/apache/gora/pull/226


   This PR still uses DataStoreFactory.getMappingFile() method, when retrieving the filename for the mapping file from the properties file, but also allows to load mappings from properties instead of only from files. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gora] alfonsonishikawa commented on pull request #226: GORA-667 Revert GORA-271 changes in hbase-store

Posted by GitBox <gi...@apache.org>.
alfonsonishikawa commented on pull request #226:
URL: https://github.com/apache/gora/pull/226#issuecomment-716894663


   Hi, @podorvanova , thank you! :D
   Something I didn't do at that moment is add a test that verifies that loading from configuration works correctly (my fault). Would you implement a test doing that so will not happen a revert again unnoticed? :)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gora] jhnmora000 commented on a change in pull request #226: GORA-667 Revert GORA-271 changes in hbase-store

Posted by GitBox <gi...@apache.org>.
jhnmora000 commented on a change in pull request #226:
URL: https://github.com/apache/gora/pull/226#discussion_r514795381



##########
File path: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
##########
@@ -887,7 +901,7 @@ private HBaseMapping readMapping(String filename) throws IOException {
       LOG.error("Error while trying to read the mapping file {}. "
               + "Expected to be in the classpath "
               + "(ClassLoader#getResource(java.lang.String)).",
-              filename) ;
+              mappingStream) ;

Review comment:
       IMO, we should use a different log message, the object `mappingStream` will not have a human readable content.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gora] alfonsonishikawa commented on pull request #226: GORA-667 Revert GORA-271 changes in hbase-store

Posted by GitBox <gi...@apache.org>.
alfonsonishikawa commented on pull request #226:
URL: https://github.com/apache/gora/pull/226#issuecomment-719076068


   > @alfonsonishikawa, thank you for your answer!
   > I will take a look tomorrow.
   
   I see you added the test to MongoDB store in https://github.com/apache/gora/pull/231
   
   Looks good to me, then. If no one has anything more to comment, I will merge tomorrow.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gora] podorvanova commented on pull request #226: GORA-667 Revert GORA-271 changes in hbase-store

Posted by GitBox <gi...@apache.org>.
podorvanova commented on pull request #226:
URL: https://github.com/apache/gora/pull/226#issuecomment-717150805


   @alfonsonishikawa, thank you for your answer!
   I will take a look tomorrow.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gora] podorvanova commented on a change in pull request #226: GORA-667 Revert GORA-271 changes in hbase-store

Posted by GitBox <gi...@apache.org>.
podorvanova commented on a change in pull request #226:
URL: https://github.com/apache/gora/pull/226#discussion_r514838256



##########
File path: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java
##########
@@ -887,7 +901,7 @@ private HBaseMapping readMapping(String filename) throws IOException {
       LOG.error("Error while trying to read the mapping file {}. "
               + "Expected to be in the classpath "
               + "(ClassLoader#getResource(java.lang.String)).",
-              filename) ;
+              mappingStream) ;

Review comment:
       Yes, you are right. I fixed the log message.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org