[GitHub] [kafka] tombentley commented on a change in pull request #11302: KAFKA-13243: KIP-773 Differentiate metric latency measured in ms and ns

[GitBox <gi...@apache.org>]

tombentley commented on a change in pull request #11302:
URL: https://github.com/apache/kafka/pull/11302#discussion_r703359283



##########
File path: clients/src/main/java/org/apache/kafka/common/network/Selector.java
##########
@@ -1272,12 +1274,27 @@ private Meter createMeter(Metrics metrics, String groupName,  Map<String, String
             return createMeter(metrics, groupName, metricTags, null, baseName, descriptiveName);
         }
 
-        private Meter createIOThreadRatioMeter(Metrics metrics, String groupName,  Map<String, String> metricTags,
+        /**
+         * This method generates `time-total` metrics with a couple of errors, no `-ns` suffix and no dash between basename

Review comment:
       ```suggestion
            * This method generates `time-total` metrics but has a couple of deficiencies: no `-ns` suffix and no dash between basename
   ```

##########
File path: docs/ops.html
##########
@@ -1890,6 +1890,16 @@ <h4><a id="selector_monitoring" href="#selector_monitoring">Common monitoring me
         <td>The average length of time the I/O thread spent waiting for a socket ready for reads or writes in nanoseconds.</td>
         <td>kafka.[producer|consumer|connect]:type=[producer|consumer|connect]-metrics,client-id=([-.\w]+)</td>
       </tr>
+      <tr>
+        <td>io-wait-time-ns-total</td>
+        <td>The total time the I/O thread spent waiting in nanoseconds</td>
+        <td>kafka.[producer|consumer|connect]:type=[producer|consumer|connect]-metrics,client-id=([-.\w]+)</td>
+      </tr>
+      <tr>
+        <td>io-waittime-total</td>
+        <td><b>*Deprecated*</b> The total time the I/O thread spent waiting in nanoseconds</td>

Review comment:
       No harm in mentioning that the replacement is `io-wait-time-ns-total`.

##########
File path: docs/ops.html
##########
@@ -1900,6 +1910,16 @@ <h4><a id="selector_monitoring" href="#selector_monitoring">Common monitoring me
         <td>The average length of time for I/O per select call in nanoseconds.</td>
         <td>kafka.[producer|consumer|connect]:type=[producer|consumer|connect]-metrics,client-id=([-.\w]+)</td>
       </tr>
+      <tr>
+        <td>io-time-ns-total</td>
+        <td>The total time the I/O thread spent doing I/O in nanoseconds</td>
+        <td>kafka.[producer|consumer|connect]:type=[producer|consumer|connect]-metrics,client-id=([-.\w]+)</td>
+      </tr>
+      <tr>
+        <td>iotime-total</td>
+        <td><b>*Deprecated*</b> The total time the I/O thread spent doing I/O in nanoseconds</td>

Review comment:
       Again, mention the replacement.

##########
File path: docs/ops.html
##########
@@ -2072,6 +2092,16 @@ <h4 class="anchor-heading"><a id="producer_monitoring" class="anchor-link"></a><
         <td>The fraction of time an appender waits for space allocation.</td>
         <td>kafka.producer:type=producer-metrics,client-id=([-.\w]+)</td>
       </tr>
+      <tr>
+        <td>bufferpool-wait-time-total</td>
+        <td><b>*Deprecated*</b> The total time an appender waits for space allocation in nanoseconds.</td>

Review comment:
       Same comment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org