[jira] [Work logged] (BEAM-5265) Can not test Timer with processing time domain

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-5265?focusedWorklogId=152328&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152328 ]

ASF GitHub Bot logged work on BEAM-5265:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Oct/18 17:49
            Start Date: 08/Oct/18 17:49
    Worklog Time Spent: 10m 
      Work Description: swegner commented on issue #6305: [BEAM-5265] Use currentProcessingTime() for onTime with processing time domain
URL: https://github.com/apache/beam/pull/6305#issuecomment-427922708
 
 
   Thanks for the contribution @JozoVilcek. Is this ready for review? If so, please assign it to a reviewer by leaving a comment with:
   
   ```
   R: @reviewerName
   ```
   
   If you need help finding a reviewer, you can check in the git commit history or component [OWNERS file](https://github.com/apache/beam/blob/master/runners/core-java/OWNERS). See: https://s.apache.org/beam-owners

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 152328)
    Time Spent: 0.5h  (was: 20m)

> Can not test Timer with processing time domain
> ----------------------------------------------
>
>                 Key: BEAM-5265
>                 URL: https://issues.apache.org/jira/browse/BEAM-5265
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core, runner-direct
>            Reporter: Jozef Vilcek
>            Assignee: Kenneth Knowles
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> I have a stateful DoFn which has a timer on PROCESSING_TIME domain. While writing tests, I noticed that it does not react to `advanceProcessingTime()` on tests stream. Problem seems to be here:
> [https://github.com/apache/beam/blob/master/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java#L260]
> I can only tell that patching this place works for direct runner tests. Not sure about broader impact on other runners since it is in `runner-core`



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)