You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "waitinfuture (via GitHub)" <gi...@apache.org> on 2023/04/07 08:39:22 UTC
[GitHub] [incubator-celeborn] waitinfuture opened a new pull request, #1413: [CELEBORN-510][FLINK] DataPartitionReader.addBuffer should not call s…
waitinfuture opened a new pull request, #1413:
URL: https://github.com/apache/incubator-celeborn/pull/1413
…endData
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
DataPartitionReader.addBuffer should not call sendData, and always trigger sendData in addReaderCredit.
To make code more concise.
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
UT and IT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1413: [CELEBORN-510][FLINK] DataPartitionReader.addBuffer should not call s…
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1413:
URL: https://github.com/apache/incubator-celeborn/pull/1413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1413: [CELEBORN-510][FLINK] DataPartitionReader.addBuffer should not call s…
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1413:
URL: https://github.com/apache/incubator-celeborn/pull/1413#discussion_r1160606127
##########
common/src/main/java/org/apache/celeborn/common/network/server/DataPartitionReader.java:
##########
@@ -125,13 +125,8 @@ public void open(FileChannel dataFileChannel, FileChannel indexFileChannel) thro
}
}
- public boolean sendWithCredit(int credit) {
- int oldCredit = credits.getAndAdd(credit);
- if (oldCredit == 0) {
- return true;
- }
-
- return false;
+ public void addCredit(int credit) {
+ credits.getAndAdd(credit);
}
public synchronized boolean readAndSend(Queue<ByteBuf> bufferQueue, Recycler bufferRecycler)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1413: [CELEBORN-510][FLINK] DataPartitionReader.addBuffer should not call s…
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #1413:
URL: https://github.com/apache/incubator-celeborn/pull/1413#discussion_r1160597271
##########
common/src/main/java/org/apache/celeborn/common/network/server/DataPartitionReader.java:
##########
@@ -125,13 +125,8 @@ public void open(FileChannel dataFileChannel, FileChannel indexFileChannel) thro
}
}
- public boolean sendWithCredit(int credit) {
- int oldCredit = credits.getAndAdd(credit);
- if (oldCredit == 0) {
- return true;
- }
-
- return false;
+ public void addCredit(int credit) {
+ credits.getAndAdd(credit);
}
public synchronized boolean readAndSend(Queue<ByteBuf> bufferQueue, Recycler bufferRecycler)
Review Comment:
better rename readAndSend method name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1413: [CELEBORN-510][FLINK] DataPartitionReader.addBuffer should not call s…
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1413:
URL: https://github.com/apache/incubator-celeborn/pull/1413#issuecomment-1500084551
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1413?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1413](https://codecov.io/gh/apache/incubator-celeborn/pull/1413?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be58da5) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/9b2b8a01ec3e6c348a82b4121e4ae58076fbd8ce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9b2b8a0) will **increase** coverage by `0.04%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #1413 +/- ##
==========================================
+ Coverage 45.01% 45.05% +0.04%
==========================================
Files 164 164
Lines 10405 10398 -7
Branches 1057 1054 -3
==========================================
+ Hits 4683 4684 +1
+ Misses 5385 5375 -10
- Partials 337 339 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1413?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...orn/common/network/server/BufferStreamManager.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1413?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zZXJ2ZXIvQnVmZmVyU3RyZWFtTWFuYWdlci5qYXZh) | `77.84% <0.00%> (+0.37%)` | :arrow_up: |
| [...orn/common/network/server/DataPartitionReader.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1413?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zZXJ2ZXIvRGF0YVBhcnRpdGlvblJlYWRlci5qYXZh) | `24.78% <0.00%> (+0.67%)` | :arrow_up: |
... and [3 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1413/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org