You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fesod.apache.org by "huangzengtian (via GitHub)" <gi...@apache.org> on 2026/02/05 06:22:19 UTC
[PR] [enhancement] Support disabling CSV quote parsing by NONE_QUOTE #846feat: [fesod]
huangzengtian opened a new pull request, #847:
URL: https://github.com/apache/fesod/pull/847
- Add NONE_QUOTE constant in CsvConstant.
- Add Javadoc to CsvReaderBuilder#quote(Character quote) for NONE_QUOTE usage
## Purpose of the pull request
Closed: #846
## What's changed?
Rationale
Currently, the quote configuration in CsvReaderBuilder does not support an explicit "disabled" state. Setting it to null is ambiguous (could mean "use default" or "disable"). This PR introduces a special constant to explicitly disable quote parsing, which is essential for processing raw TSV/CSV data (like Amazon reports) where quotes are part of the literal content and should not be escaped or wrapped.
Design Decisions
Introduced CsvConstant.NONE_QUOTE ('\0'): Followed the industrial practice of Apache Commons CSV (where withQuote(null) disables quoting).
Enhanced Javadoc: Added clear instructions in CsvReaderBuilder#quote to guide users on how to use NONE_QUOTE.
## Checklist
- [✓] I have read the [Contributor Guide](https://fesod.apache.org/community/contribution/).
- [✓] I have written the necessary doc or comment.
- [✓] I have added the necessary unit tests and all cases have passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org
Re: [PR] refactor: support disabling CSV quote parsing by NONE_QUOTE [fesod]
Posted by "delei (via GitHub)" <gi...@apache.org>.
delei merged PR #847:
URL: https://github.com/apache/fesod/pull/847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org