You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2017/01/29 22:49:56 UTC
[GitHub] zeppelin pull request #1959: [ZEPPELIN-2026] Flaky Test: WebDriverManager.ge...
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/1959
[ZEPPELIN-2026] Flaky Test: WebDriverManager.getWebDriver() fails with Unable to locate element 'WebSocket Connected'
### What is this PR for?
Selenium test sometimes fails with
```
Caused by: org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"//i[@tooltip='WebSocket Connected']"}
```
This PR gives enough timeout (30s) for waiting 'WebSocket Connected' element.
Tested in my travis account 5 times and they're all green.
https://travis-ci.org/Leemoonsoo/zeppelin/builds/196428795
https://travis-ci.org/Leemoonsoo/zeppelin/builds/196429337
https://travis-ci.org/Leemoonsoo/zeppelin/builds/196429559
https://travis-ci.org/Leemoonsoo/zeppelin/builds/196429593
https://travis-ci.org/Leemoonsoo/zeppelin/builds/196430020
However, I'm not 100% sure if it really fixes the flaky test.
So, I'd like to merge this PR but keep ZEPPELIN-2026 open for next 1 week.
And then see if no selenium test fails with the error for next 1 week to close ZEPPELIN-2026.
### What type of PR is it?
Improvement
### Todos
* [x] - Increase timeout of detecting 'connected'
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2026
### How should this be tested?
CI green on Selenium test profile
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-2026
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1959.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1959
----
commit 87432d5b88c3397d0e1a9fc6c87f1c82509a57c4
Author: Lee moon soo <mo...@apache.org>
Date: 2017-01-29T21:56:28Z
increase timeout
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1959: [ZEPPELIN-2026] Flaky Test: WebDriverManager.ge...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1959
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1959: [ZEPPELIN-2026] Flaky Test: WebDriverManager.getWebDri...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1959
Merge to master if no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1959: [ZEPPELIN-2026] Flaky Test: WebDriverManager.getWebDri...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1959
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1959: [ZEPPELIN-2026] Flaky Test: WebDriverManager.getWebDri...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1959
Good plan :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---