You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Melloware (Jira)" <de...@myfaces.apache.org> on 2022/12/19 13:48:00 UTC

[jira] [Created] (MYFACES-4536) PartialResponseWriter: Do no wrap the writer

Melloware created MYFACES-4536:
----------------------------------

             Summary: PartialResponseWriter: Do no wrap the writer
                 Key: MYFACES-4536
                 URL: https://issues.apache.org/jira/browse/MYFACES-4536
             Project: MyFaces Core
          Issue Type: Improvement
          Components: General
    Affects Versions: 4.0.0-RC2, 2.3-next-M7, 2.3.10, 2.2.14
            Reporter: Melloware


Per BalusC:

Since JSF 2.3 the default constructor of {{FacesWrapper}} subclasses has been deprecated in order to force implementors to instead use the constructor taking the wrapped instance (and to raise their awareness), so that logically the inherited {{getWrapped()}} method will be used throughout the implementation instead of the local {{wrapped}} variable. This will ensure that the correct implementation is returned and correct behavior is performed might the {{FacesWrapper}} implementation itself being wrapped by yet another {{FacesWrapper}} implementation further down the chain. Because, when the {{FacesWrapper}} implementation incorrectly/accidentally uses the local {{wrapped}} variable instead of the {{getWrapped()}} method, then that other {{FacesWrapper}} implementation will basically be completely ignored, hereby breaking the decorator pattern.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)