You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/28 13:13:23 UTC

[GitHub] [airflow] flvndh opened a new pull request #10627: Wrong key in DAGs Persistent Volume Claim

flvndh opened a new pull request #10627:
URL: https://github.com/apache/airflow/pull/10627


   The `storageClassName` in `chart/templates/dags-persistent-volume-claim.yaml` is referencing the value `dags.persistence.storageClass` that does not exist in `chart/values.yaml`.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10627: Wrong key in DAGs Persistent Volume Claim

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10627:
URL: https://github.com/apache/airflow/pull/10627#issuecomment-682655927


   Awesome work, congrats on your first merged pull request!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10627: Wrong key in DAGs Persistent Volume Claim

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10627:
URL: https://github.com/apache/airflow/pull/10627#issuecomment-682552883


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better πŸš€.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://apache-airflow-slack.herokuapp.com/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] flvndh commented on pull request #10627: Wrong key in DAGs Persistent Volume Claim

Posted by GitBox <gi...@apache.org>.
flvndh commented on pull request #10627:
URL: https://github.com/apache/airflow/pull/10627#issuecomment-682710498


   @mik-laj I'd be glad to help you with this as well πŸ˜‰


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj merged pull request #10627: Wrong key in DAGs Persistent Volume Claim

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #10627:
URL: https://github.com/apache/airflow/pull/10627


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #10627: Wrong key in DAGs Persistent Volume Claim

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10627:
URL: https://github.com/apache/airflow/pull/10627#issuecomment-682661264


   Good catch! What are your plans for your next contribution?  Would you be interested in creating the [values.schema.json file](https://helm.sh/docs/topics/charts/#schema-files) to validate values.yaml file?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org