You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "shiavm006 (via GitHub)" <gi...@apache.org> on 2025/12/07 10:37:03 UTC
[PR] Fix XCom.get_value() failing in extra link plugins when SUPERVISOR_COMMS unavailable [airflow]
shiavm006 opened a new pull request, #59154:
URL: https://github.com/apache/airflow/pull/59154
`XCom.get_value()` crashes with `ImportError` when called from extra link plugins because `SUPERVISOR_COMMS` only exists in task execution context, not in API server context.
- Added fallback to read XCom from database when `SUPERVISOR_COMMS` is unavailable
- All XCom retrieval methods (`get_one`, `get_all`, `_get_xcom_db_ref`) now check for `SUPERVISOR_COMMS` and fallback to database reads automatically
closes: #59093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix XCom.get_value() failing in extra link plugins when SUPERVISOR_COMMS unavailable [airflow]
Posted by "shiavm006 (via GitHub)" <gi...@apache.org>.
shiavm006 commented on PR #59154:
URL: https://github.com/apache/airflow/pull/59154#issuecomment-3638179667
sorry for trouble i just missed it will make sure too keep this in mind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix XCom.get_value() failing in extra link plugins when SUPERVISOR_COMMS unavailable [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #59154:
URL: https://github.com/apache/airflow/pull/59154#issuecomment-3629376481
Yep. Closing it. Not the right way of fixing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix XCom.get_value() failing in extra link plugins when SUPERVISOR_COMMS unavailable [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #59154:
URL: https://github.com/apache/airflow/pull/59154#issuecomment-3663971014
All good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix XCom.get_value() failing in extra link plugins when SUPERVISOR_COMMS unavailable [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #59154:
URL: https://github.com/apache/airflow/pull/59154#issuecomment-3621901053
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix XCom.get_value() failing in extra link plugins when SUPERVISOR_COMMS unavailable [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on PR #59154:
URL: https://github.com/apache/airflow/pull/59154#issuecomment-3624389247
Thanks @shiavm006 !
Could you please run `prek` locally to fix static checks. Some of them will automatically fixed by it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix XCom.get_value() failing in extra link plugins when SUPERVISOR_COMMS unavailable [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #59154: Fix XCom.get_value() failing in extra link plugins when SUPERVISOR_COMMS unavailable
URL: https://github.com/apache/airflow/pull/59154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org