[GitHub] sijie commented on a change in pull request #80: BOOKKEEPER-816: use native fallocate to improve journal allocation

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #80: BOOKKEEPER-816: use native fallocate to improve journal allocation
URL: https://github.com/apache/bookkeeper/pull/80#discussion_r178196704
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
 ##########
 @@ -797,6 +805,8 @@ public void scanJournal(long journalId, long journalPos, JournalScanner scanner)
                 if (!isPaddingRecord) {
                     scanner.process(journalVersion, offset, recBuff);
                 }
+                // update last log mark during replaying
+                lastLogMark.setCurLogMark(journalId, offset);
             }
 
 Review comment:
   it is already listed in the description. it is a portback, but if you feel strong about it, I will break it down.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services