You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/01 04:42:37 UTC
[GitHub] [incubator-apisix] wingsjj opened a new issue #1789: bug: The test case does not take into account tengine
wingsjj opened a new issue #1789:
URL: https://github.com/apache/incubator-apisix/issues/1789
### Issue description
When I tried to migrate CI from Travis to GitHub action, I found that this test case does not pass when using Tengine.
https://github.com/wingsjj/incubator-apisix/runs/824980221?check_suite_focus=true#step:6:130
### Environment
* apisix version (cmd: `apisix version`): 1.4
* OS: Ubuntu 18.04
### Minimal test code / Steps to reproduce the issue
1.https://github.com/wingsjj/incubator-apisix/runs/824980221?check_suite_focus=true#step:6:130
2.https://github.com/apache/incubator-apisix/blob/master/t/node/remote-addr-ipv6.t#L117
### What's the actual result? (including assertion message & call stack if applicable)
> Failed test 'TEST 4: IPv6 /hello - response_body - response is expected (repeated req 0, req 0)'
> at /home/runner/work/incubator-apisix/incubator-apisix/test-nginx/lib/Test/Nginx/Socket.pm line 1589.
> @@ -3,7 +3,7 @@
> received: HTTP/1.1 200 OK
> received: Content-Type: text/plain
> received: Connection: close
> -received: Server: openresty
> +received: Server: Tengine
> received:
> received: hello world
> failed to receive a line: closed []
> Test Summary Report
> -------------------
> t/node/remote-addr-ipv6.t (Wstat: 256 Tests: 15 Failed: 1)
> Failed test: 11
> Non-zero exit status: 1
> Files=119, Tests=3969, 959 wallclock secs ( 0.95 usr 0.18 sys + 130.74 cusr 27.03 csys = 158.90 CPU)
> Result: FAIL
> ##[error]Process completed with exit code 1.
### What's the expected result?
Test case passed successfully.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on issue #1789: bug: The test case does not take into account tengine
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1789:
URL: https://github.com/apache/incubator-apisix/issues/1789#issuecomment-652201356
you can update the test case if you need
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on issue #1789: bug: The test case does not take into account tengine
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1789:
URL: https://github.com/apache/incubator-apisix/issues/1789#issuecomment-652729559
@wingsjj that is cool. welcome PR ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] moonming closed issue #1789: bug: The test case does not take into account tengine
Posted by GitBox <gi...@apache.org>.
moonming closed issue #1789:
URL: https://github.com/apache/incubator-apisix/issues/1789
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] wingsjj commented on issue #1789: bug: The test case does not take into account tengine
Posted by GitBox <gi...@apache.org>.
wingsjj commented on issue #1789:
URL: https://github.com/apache/incubator-apisix/issues/1789#issuecomment-652322407
I updated it.
https://github.com/wingsjj/incubator-apisix/blob/master/t/node/remote-addr-ipv6.t#L117
And test case passed successfully.
https://github.com/wingsjj/incubator-apisix/actions/runs/153889200
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org