You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lriggs (via GitHub)" <gi...@apache.org> on 2025/02/08 00:33:20 UTC
[PR] GH-55 Renable tests after fixing link error. [arrow-java]
lriggs opened a new pull request, #595:
URL: https://github.com/apache/arrow-java/pull/595
###Rationale for this change
I fixed the linking error here: https://github.com/apache/arrow/pull/45114/
###What changes are included in this PR?
Reenabling some disabled tests.
###Are these changes tested?
Yes, they are tests.
###Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: [Gandiva] Re-enable tests [arrow-java]
Posted by "lriggs (via GitHub)" <gi...@apache.org>.
lriggs commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2657835587
Latest failures were because I only updated the windows build in rc.yml. Just fixed that for mac and linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: Renable tests after fixing link error [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2652695936
Looks like one more minor CI nit:
```
Error: /home/runner/work/arrow-java/arrow-java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/FilterProjectTest.java:37:8: Unused import: org.junit.jupiter.api.Disabled. [UnusedImports]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: [Gandiva] Re-enable tests [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2661182430
Ah, we need to expire a cache when we change vcpkg version. Could you try this?
```diff
diff --git a/compose.yaml b/compose.yaml
index 58a19676..b125c3c9 100644
--- a/compose.yaml
+++ b/compose.yaml
@@ -92,12 +92,12 @@ services:
# Usage:
# docker compose build vcpkg-jni
# docker compose run vcpkg-jni
- image: ${REPO}:${ARCH}-vcpkg-jni
+ image: ${REPO}:${ARCH}-vcpkg-jni-${VCPKG}
build:
context: .
dockerfile: ci/docker/vcpkg-jni.dockerfile
cache_from:
- - ${REPO}:${ARCH}-vcpkg-jni
+ - ${REPO}:${ARCH}-vcpkg-jni-${VCPKG}
args:
base: ${ARROW_REPO}:${ARCH}-python-${PYTHON}-wheel-manylinux-2014-vcpkg-${VCPKG}
volumes:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: [Gandiva] Re-enable tests [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2655390671
C++ version must not be related.
https://github.com/apache/arrow/pull/45114 just updated LLVM version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: [Gandiva] Re-enable tests [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #595:
URL: https://github.com/apache/arrow-java/pull/595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: [Gandiva] Re-enable tests [arrow-java]
Posted by "lriggs (via GitHub)" <gi...@apache.org>.
lriggs commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2655373474
Now its failing with "Gandiva Failed to make LLVM module due to Could not create LLJIT instance: Symbols not found: [ llvm_orc_registerEHFrameSectionWrapper ]" which is what should be fixed in my other change in apache/arrow.
Seems to be using the 18.2 jars: /home/runner/.m2/repository/org/apache/arrow/arrow-avro/18.2.0/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: Renable tests after fixing link error [arrow-java]
Posted by "lriggs (via GitHub)" <gi...@apache.org>.
lriggs commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2652348914
Thanks. I updated vcpkg as well now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: [Gandiva] Re-enable tests [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2657998657
Oh, sorry. It's my fault...
We just need to use main only for Linux because Linux build only uses vcpkg to install LLVM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: Renable tests after fixing link error [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2644725420
We use the latest release for push/pull request: https://github.com/apache/arrow-java/blob/a5b86049261530d41fbbdd23324420f0c1d14431/.github/workflows/rc.yml#L110-L113
We use the main branch for schedule: https://github.com/apache/arrow-java/blob/a5b86049261530d41fbbdd23324420f0c1d14431/.github/workflows/rc.yml#L114-L119
We need to update https://github.com/apache/arrow-java/blob/a5b86049261530d41fbbdd23324420f0c1d14431/.env#L57 to use vcpkg configuration introduced by https://github.com/apache/arrow/pull/45114 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: [Gandiva] Re-enable tests [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2655472903
Ah, I see what you meant by the original comment now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55 Renable tests after fixing link error. [arrow-java]
Posted by "lriggs (via GitHub)" <gi...@apache.org>.
lriggs commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2644374672
How do you specify the arrow version used to build/test with arrow-java (so that I know it has my fix)? Does it always use the latest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: [Gandiva] Re-enable tests [arrow-java]
Posted by "lriggs (via GitHub)" <gi...@apache.org>.
lriggs commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2657382478
I'll try your suggested change @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: [Gandiva] Re-enable tests [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2655379239
Ah, the CI here uses the latest released version of the C++ libraries, not the development version...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: [Gandiva] Re-enable tests [arrow-java]
Posted by "lriggs (via GitHub)" <gi...@apache.org>.
lriggs commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2660018485
Strange, it still seems to be using the old vcpkg.
```
2025-02-14T00:07:03.2003955Z CMake Warning at /opt/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package):
2025-02-14T00:07:03.2004967Z Could not find a configuration file for package "LLVM" that is compatible
2025-02-14T00:07:03.2005618Z with requested version "19.1".
```
....
```
2025-02-14T00:07:03.2600773Z -- Found LLVMAlt: 17.0.2
2025-02-14T00:07:03.2601530Z -- Using LLVMConfig.cmake in: /opt/vcpkg/installed/amd64-linux-static-release/share/llvm
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: [Gandiva] Re-enable tests [arrow-java]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2655442324
Ah, I thought that updating `VCPKG` in `.env` is enough to use LLVM 18 but we refer `ci/vcpkg` in apache/arrow here...: https://github.com/apache/arrow-java/blob/34e2b08ff1b06c864f63f3ad1a3a771d0e7b058b/ci/docker/vcpkg-jni.dockerfile#L26
The log shows that we use LLVM 17:
https://github.com/apache/arrow-java/actions/runs/13298859368/job/37137015507?pr=595#step:10:1663
```text
-- Found LLVMAlt: 17.0.2
```
OK. Let's use main for now:
```diff
diff --git a/.github/workflows/rc.yml b/.github/workflows/rc.yml
index faad5983..f2666a31 100644
--- a/.github/workflows/rc.yml
+++ b/.github/workflows/rc.yml
@@ -299,13 +299,13 @@ jobs:
shell: bash
run: |
tar -xf apache-arrow-java-*.tar.gz --strip-components=1
- - name: Download the latest Apache Arrow C++
- if: github.event_name != 'schedule'
- shell: bash
- run: |
- ci/scripts/download_cpp.sh
+ # - name: Download the latest Apache Arrow C++
+ # if: github.event_name != 'schedule'
+ # shell: bash
+ # run: |
+ # ci/scripts/download_cpp.sh
- name: Checkout Apache Arrow C++
- if: github.event_name == 'schedule'
+ # if: github.event_name == 'schedule'
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
repository: apache/arrow
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: [Gandiva] Re-enable tests [arrow-java]
Posted by "lriggs (via GitHub)" <gi...@apache.org>.
lriggs commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2666735479
Ok, just pushed a change to expire the cache. Hopefully it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: [Gandiva] Re-enable tests [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2669987288
Looks like that worked!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: [Gandiva] Re-enable tests [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2655388828
We could either make the skips conditional on the version of the C++ code somehow, or otherwise just always test against the dev release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: [Gandiva] Re-enable tests [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2655392243
But we're building 19.0.0, not `main`: https://github.com/apache/arrow-java/actions/runs/13298859368/job/37137015507?pr=595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-55: [Gandiva] Renable tests [arrow-java]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #595:
URL: https://github.com/apache/arrow-java/pull/595#issuecomment-2655066900
There's others - are you able to run the build locally at all to test?
```
Error: /home/runner/work/arrow-java/arrow-java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/FilterTest.java:37:8: Unused import: org.junit.jupiter.api.Disabled. [UnusedImports]
Error: /home/runner/work/arrow-java/arrow-java/gandiva/src/test/java/org/apache/arrow/gandiva/evaluator/ProjectorDecimalTest.java:45:8: Unused import: org.junit.jupiter.api.Disabled. [UnusedImports]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org