[GitHub] [hadoop] ben-roling commented on issue #666: HADOOP-16221 add option to fail operation on metadata write failure

[GitBox <gi...@apache.org>]

ben-roling commented on issue #666: HADOOP-16221 add option to fail operation on metadata write failure
URL: https://github.com/apache/hadoop/pull/666#issuecomment-478111788
 
 
   Thanks for the feedback @steveloughran !
   
   To be honest, the purpose of the retry annotations hadn't really sunk in for me until you mentioned them.  I pushed an update but I don't think I'm grasping the annotations well enough to have gotten it correct.  It's not clear to me if the annotation is supposed to be about the code within the immediate scope of the method or the transitive scope.  For example, the code immediately within the finishedWrite() method is not retried and the method itself does not translate any exceptions that occur within it.  As such, I documented it as "OnceRaw".  That said, S3Guard.putAndReturn() transitively does include retries, and there is translation on those exceptions.  That occurs within DynamoDBMetadataStore.processBatchWriteRequest().  This had me wondering whether finishedWrite() should have been documented as "RetryTranslated".
   
   Further complicating things is that finishedWrite() now sometimes (depending on configuration) swallows exceptions.  I guess I could have used a string argument passed to the annotation to document that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org