You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/03/12 19:01:47 UTC

[GitHub] [trafficcontrol] dsouza93 opened a new issue #5638: MSO Topologies Breaks "Last Header Rewrite Rules"

dsouza93 opened a new issue #5638:
URL: https://github.com/apache/trafficcontrol/issues/5638


   <!--
   ************ STOP!! ************
   If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
   
   - For *SUPPORT QUESTIONS*, use the Traffic Control slack (https://s.apache.org/atc-slack)
   or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
   - Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
   -->
   
   ## I'm submitting a ...
   <!-- delete all those that don't apply -->
   <!--- security vulnerability (STOP!! - see above)-->
   -  bug report
   ## Traffic Control components affected ...
   <!-- delete all those that don't apply -->
   -  Traffic Ops
   -  Traffic Ops ORT
   
   ## Current behavior:
   <!-- Describe how the bug manifests -->
   If you are using an MSO like topology, the "Last Header Rewrite" rules do not get applied in the remap config. By MSO like topology I mean one in which origins are used as the root of the topology. 
   I am assuming this is because code in ORT that determines what is the most outer most tier of the CDN is incorrectly assuming that the origin is the outmost tier, but this is just a guess. 
   
   You cannot get around this bug by placing the "Last Header Rewrite" as the "Inner Header Rewrite". I tried this with no success. 
   
   ## Expected behavior:
   <!-- Describe what the behavior would be without the bug -->
   With MSO like topologies, the "Last Header Rewrite" should be applied on the final tier of the CDN.
   
   ## Minimal reproduction of the problem with instructions:
   <!--
   If the current behavior is a bug, please provide the *STEPS TO REPRODUCE* and
   include the applicable TC version.
   -->
   Create an MSO topology (one with a cache group made up of ORG servers) . Apply it to an MSO delivery service that has said ORG servers assigned. Set a "Last Header Rewrite Rule" on that delivery service. Run ORT and notice that the hdr_rw file gets placed on disk, but does not get configured in the remap.config.
   
   ## Anything else:
   <!--
   e.g. stacktraces, related issues, suggestions how to fix (feel free to delete
   this section)
   -->
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       https://apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] rob05c commented on issue #5638: MSO Topologies Breaks "Last Header Rewrite Rules"

Posted by GitBox <gi...@apache.org>.
rob05c commented on issue #5638:
URL: https://github.com/apache/trafficcontrol/issues/5638#issuecomment-798963321


   This is fixed by https://github.com/apache/trafficcontrol/pull/5642 (and its dependent PRs).
   I'm not sure exactly the root or where it was fixed. But those changesets fix a number of related things, including minor fallback and header rewrite injection.
   
   I specifically tested this with #5642, and the MSO hdr_rw_last_ was properly injected on the last cache tier, both the remap.config line directive and the hdr_rw_last_ file were created correctly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] rob05c commented on issue #5638: MSO Topologies Breaks "Last Header Rewrite Rules"

Posted by GitBox <gi...@apache.org>.
rob05c commented on issue #5638:
URL: https://github.com/apache/trafficcontrol/issues/5638#issuecomment-805877400


   #5642 is merged, which fixes this. Closing. Reopen or make a new case if it shows up again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] rob05c closed issue #5638: MSO Topologies Breaks "Last Header Rewrite Rules"

Posted by GitBox <gi...@apache.org>.
rob05c closed issue #5638:
URL: https://github.com/apache/trafficcontrol/issues/5638


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org