You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ramkrish86 <gi...@git.apache.org> on 2016/01/20 18:43:43 UTC
[GitHub] flink pull request: FLINK-3135 Add chainable driver for UNARY_NO_O...
GitHub user ramkrish86 opened a pull request:
https://github.com/apache/flink/pull/1530
FLINK-3135 Add chainable driver for UNARY_NO_OP strategy(Ram)
My first flink PR. A simple way to add a Chainable Driver for UNARY_NO_OP. Just followed the existing code pieces and also reading the NoOpDriver created the NoOpChainedDriver. Just trying to learn and happy to work on feedbacks/comments.
Since here the input just needs to be passed to the output there is no need for any class to be loaded I felt. Hence most of the abstract APIs have empty implementations.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ramkrish86/flink FLINK-3135
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1530.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1530
----
commit 16b755a78e2cd56e193363dc3cd77d87eeaa7a16
Author: ramkrishna <ra...@gmail.com>
Date: 2016-01-20T17:22:55Z
FLINK-3135 Add chainable driver for UNARY_NO_OP strategy(Ram)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3135 Add chainable driver for UNARY_NO_O...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1530
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3135 Add chainable driver for UNARY_NO_O...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1530#issuecomment-174540760
Thanks for the PR! Looks good!
Will merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---