You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Santhosh Srinivasan (JIRA)" <ji...@apache.org> on 2008/12/16 20:18:44 UTC
[jira] Created: (PIG-566) Dump and store outputs do not match for
PigStorage
Dump and store outputs do not match for PigStorage
--------------------------------------------------
Key: PIG-566
URL: https://issues.apache.org/jira/browse/PIG-566
Project: Pig
Issue Type: Bug
Affects Versions: types_branch
Reporter: Santhosh Srinivasan
Priority: Minor
Fix For: types_branch
The dump and store formats for PigStorage do not match for longs and floats.
{code}
grunt> y = foreach x generate {(2985671202194220139L)};
grunt> describe y;
y: {{(long)}}
grunt> dump y;
({(2985671202194220139L)})
grunt> store y into 'y';
grunt> cat y
{(2985671202194220139)}
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864336#action_12864336 ]
Gianmarco De Francisci Morales commented on PIG-566:
----------------------------------------------------
What should the default format be? With or without L/F at the end?
The loader function already checks for the presence of a letter at the end, so we can accept both.
I think that without is better anyway, it complies to normal Java behaviour. The L/F is used only in source code.
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Santhosh Srinivasan
> Priority: Minor
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gianmarco De Francisci Morales updated PIG-566:
-----------------------------------------------
Status: In Progress (was: Patch Available)
TestConversions fails reasons unrelated to the patch (sent an email about this), addressing other test problems.
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865908#action_12865908 ]
Olga Natkovich commented on PIG-566:
------------------------------------
what happens if you re-run the failing tests manually? (We can't commit code if there are failures in tests)
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gianmarco De Francisci Morales updated PIG-566:
-----------------------------------------------
Status: In Progress (was: Patch Available)
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865971#action_12865971 ]
Gianmarco De Francisci Morales commented on PIG-566:
----------------------------------------------------
It still fails also when manually run because there is a bug in UTF8StorageConverter.
This patch just made it pop out.
The problem is that bytesToInteger relied on the final L to recognize longs and avoid converting them.
More specifically, using Double d = Double.valueOf(s);
The method checks if the integer is convertible to a double and the double is actually a int by hand.
The check is performed only on the upper bound, so it would fail if we passed a double that is less than Integer.MIN_VALUE
I actually also do not understand why the check was done in this way:
d.doubleValue() > mMaxInt.doubleValue() + 1.0
I refactored it into :
Double.compare(d.doubleValue(), mMaxInt.doubleValue()) > 0
I added some unit tests for these edge cases.
I adapted also bytesToLong for consistency, even though the bug is not as evident because of rounding (MAX_LONG as a double is smaller than as a long).
The new patch passes all tests locally.
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gianmarco De Francisci Morales updated PIG-566:
-----------------------------------------------
Attachment: PIG-566.patch
Addressed the issues highlighted in Daniel's comment
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-566:
---------------------------
Fix Version/s: (was: 0.7.0)
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866214#action_12866214 ]
Daniel Dai commented on PIG-566:
--------------------------------
Usually we convert a double into an integer by truncating. Returning null in this case break backward compatibility unnecessarily. Ideally the behavior of bytesToInteger is:
* Integer.MIN_INTEGER <= d < Integer.MAX_INTEGER+1: return ceil(d)
* Return null otherwise
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gianmarco De Francisci Morales updated PIG-566:
-----------------------------------------------
Status: Patch Available (was: In Progress)
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gianmarco De Francisci Morales updated PIG-566:
-----------------------------------------------
Attachment: PIG-566.patch
Ok, I understand.
Anyway this works only for integers, because their MAX/MIN_VALUE can be represented exactly as a double. The same cannot be done for longs.
You can try yourself:
Integer.MIN_VALUE: -2147483648
As a double: -2.147483648E9
Integer.MAX_VALUE: 2147483647
As a double: 2.147483647E9
Long.MIN_VALUE: -9223372036854775808
As a double: -9.223372036854776E18
Long.MAX_VALUE: 9223372036854775807
As a double: 9.223372036854776E18
The double values for longs are rounded up. Adding or subtracting 1 to MAX/MIN does not make sense for longs.
For example Long.valueOf(Long.MAX_VALUE).doubleValue() + 1 gets casted without errors.
Have a look at the test I added, TestConversions.testOverflow.
To make the test pass I had to add/subtract 10000 to the MAX/MIN in order to have an invalid long.
So, I restored the +/-1 in Utf8StorageConverter for Integers. I added a >= / <= to avoid converting Integer.MAX_VALUE + 1 and Integer.MIN_VALUE -1.
For long, according to me, it does not make sense, because +/-1 is not enough to make a different double.
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gianmarco De Francisci Morales updated PIG-566:
-----------------------------------------------
Status: Patch Available (was: Open)
Affects Version/s: 0.7.0
0.8.0
(was: 0.2.0)
Fix Version/s: 0.7.0
0.8.0
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12867878#action_12867878 ]
Gianmarco De Francisci Morales commented on PIG-566:
----------------------------------------------------
I submitted to hudson 2 days ago, but still no result.
Is there some problem? Should I resubmit it?
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gianmarco De Francisci Morales updated PIG-566:
-----------------------------------------------
Status: In Progress (was: Patch Available)
TestTextDataParser.testLong had a problem I introduced with the last revision, the others are simply hudson problems.
I still do not understand the "mMaxInt.doubleValue() + 1.0" rationale. If we are converting a fraction to an int, we should probably return null, as a fraction is not a valid int.
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gianmarco De Francisci Morales updated PIG-566:
-----------------------------------------------
Status: Patch Available (was: In Progress)
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gianmarco De Francisci Morales updated PIG-566:
-----------------------------------------------
Status: In Progress (was: Patch Available)
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gianmarco De Francisci Morales updated PIG-566:
-----------------------------------------------
Status: Patch Available (was: In Progress)
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866076#action_12866076 ]
Daniel Dai commented on PIG-566:
--------------------------------
Hi, Gianmarco
You are right there is a bug in TestConversions.bytesToInt. The problem is it cannot deal with negative large number. Positive large number is fine. mMaxInt.doubleValue() + 1.0 is trying to deal with the case of mMaxInt plus a fraction, which will truncate into mMaxInt. So I think we should keep this and deal with the negative case.
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Mridul Muralidharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868155#action_12868155 ]
Mridul Muralidharan commented on PIG-566:
-----------------------------------------
Just to point out an error in the comment above :
For the case of
* Integer.MIN_INTEGER <= d < Integer.MAX_INTEGER+1:
pig should return floor(d), not ceil(d)
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gianmarco De Francisci Morales updated PIG-566:
-----------------------------------------------
Attachment: PIG-566.patch
Attached a patch that modifies TupleFormat.
The online documentation needs to be changed accordignly.
For example, in Pig Latin Reference 2, the Data Types section. But probably in other places as well.
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Attachments: PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866728#action_12866728 ]
Hadoop QA commented on PIG-566:
-------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12444306/PIG-566.patch
against trunk revision 943522.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/327/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/327/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/327/console
This message is automatically generated.
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865497#action_12865497 ]
Hadoop QA commented on PIG-566:
-------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12444036/PIG-566.patch
against trunk revision 941976.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 12 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/320/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/320/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/320/console
This message is automatically generated.
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12867373#action_12867373 ]
Daniel Dai commented on PIG-566:
--------------------------------
+1 once hudson test pass.
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-566:
---------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
Yes, my mistake. Thanks Mridul. Fortunately Gianmarco doesn't listen to me :) I manually test the patch, all tests pass. Committed to trunk. Thanks Gianmarco!
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gianmarco De Francisci Morales updated PIG-566:
-----------------------------------------------
Attachment: PIG-566.patch
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865274#action_12865274 ]
Hadoop QA commented on PIG-566:
-------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12443961/PIG-566.patch
against trunk revision 941976.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/309/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/309/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/309/console
This message is automatically generated.
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866679#action_12866679 ]
Daniel Dai commented on PIG-566:
--------------------------------
Yes, you are right. This trick does not always work due to the rounding. But the original code seems no harm to try to do that. The bug in the original code is the negative case. As long as we address the negative case we fix the test failure. I don't think we should go beyond that in this patch. Also for the L/l, F/f suffix part, user can generate input data externally (not through TupleFormat), in this case, we still want to recognize these suffix.
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gianmarco De Francisci Morales updated PIG-566:
-----------------------------------------------
Status: Patch Available (was: In Progress)
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gianmarco De Francisci Morales updated PIG-566:
-----------------------------------------------
Attachment: PIG-566.patch
Modified unit tests to comply to the new format.
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12867898#action_12867898 ]
Daniel Dai commented on PIG-566:
--------------------------------
Seems hudson is down. I will manually run the tests.
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai reassigned PIG-566:
------------------------------
Assignee: Gianmarco De Francisci Morales
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865579#action_12865579 ]
Gianmarco De Francisci Morales commented on PIG-566:
----------------------------------------------------
TestConversions is the only test that fails, but it is unrelated to the patch.
It is ready for review.
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864567#action_12864567 ]
Daniel Dai commented on PIG-566:
--------------------------------
Agree, I vote for without L/F.
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.2.0
> Reporter: Santhosh Srinivasan
> Priority: Minor
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-566) Dump and store outputs do not match for
PigStorage
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866057#action_12866057 ]
Hadoop QA commented on PIG-566:
-------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12444157/PIG-566.patch
against trunk revision 941976.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/312/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/312/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/312/console
This message is automatically generated.
> Dump and store outputs do not match for PigStorage
> --------------------------------------------------
>
> Key: PIG-566
> URL: https://issues.apache.org/jira/browse/PIG-566
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0, 0.8.0
> Reporter: Santhosh Srinivasan
> Assignee: Gianmarco De Francisci Morales
> Priority: Minor
> Fix For: 0.7.0, 0.8.0
>
> Attachments: PIG-566.patch, PIG-566.patch, PIG-566.patch
>
>
> The dump and store formats for PigStorage do not match for longs and floats.
> {code}
> grunt> y = foreach x generate {(2985671202194220139L)};
> grunt> describe y;
> y: {{(long)}}
> grunt> dump y;
> ({(2985671202194220139L)})
> grunt> store y into 'y';
> grunt> cat y
> {(2985671202194220139)}
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.