[GitHub] [spark] adjordan edited a comment on pull request #29080: [SPARK-32271][ML] Add option for k-fold cross-validation to CrossValidator

[GitBox <gi...@apache.org>]

adjordan edited a comment on pull request #29080:
URL: https://github.com/apache/spark/pull/29080#issuecomment-658579068


   Yes, I know the difference between the two. I just assumed that `MLUtils.kFold` was doing the splits according to the k-fold method, given the name, and not the random sub-sampling method. But I suppose changing the name of that method is outside the scope of what I'm trying to add.
   
   In that case, it seems that I should add an additional `method` parameter where you can select k-fold or random sub-sampling. If I end up doing that, should I continue with this PR or open a new one?
   
   Thoughts @viirya?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org