[GitHub] piiswrong commented on a change in pull request #11021: [MXNET-380] [WIP] count_include_pad argument for Avg Pooling

[GitBox <gi...@apache.org>]

piiswrong commented on a change in pull request #11021: [MXNET-380] [WIP] count_include_pad argument for Avg Pooling
URL: https://github.com/apache/incubator-mxnet/pull/11021#discussion_r189983506
 
 

 ##########
 File path: src/operator/nn/pooling-inl.h
 ##########
 @@ -50,6 +50,7 @@ struct PoolingParam : public dmlc::Parameter<PoolingParam> {
   bool global_pool;
   bool cudnn_off;
   dmlc::optional<int> p_value;
+  dmlc::optional<bool> count_include_pad;
 
 Review comment:
   doesn't need to be optional. Just set to the previous default

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services