[jira] [Commented] (HIVE-12990) LLAP: ORC cache NPE without FileID support

["Gopal V (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-12990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131662#comment-15131662 ] 

Gopal V commented on HIVE-12990:
--------------------------------

Looks like this still sends through a NULL fileId through - the auto-unbox here throws an NPE

{code}
  @Override
  public EncodedReader encodedReader(
      Long fileId, DataCache dataCache, DataReader dataReader, PoolFactory pf) throws IOException {
    return new EncodedReaderImpl(fileId, types,
        codec, bufferSize, rowIndexStride, dataCache, dataReader, pf);
  }
{code}

{code}
Caused by: java.lang.NullPointerException
        at org.apache.hadoop.hive.ql.io.orc.encoded.ReaderImpl.encodedReader(ReaderImpl.java:38)
        at org.apache.hadoop.hive.llap.io.encoded.OrcEncodedDataReader.performDataRead(OrcEncodedDataReader.java:331)
        at org.apache.hadoop.hive.llap.io.encoded.OrcEncodedDataReader$4.run(OrcEncodedDataReader.java:215)
        at org.apache.hadoop.hive.llap.io.encoded.OrcEncodedDataReader$4.run(OrcEncodedDataReader.java:212)
        at java.security.AccessController.doPrivileged(Native Method)
        at javax.security.auth.Subject.doAs(Subject.java:415)
        at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657)
        at org.apache.hadoop.hive.llap.io.encoded.OrcEncodedDataReader.callInternal(OrcEncodedDataReader.java:212)
        at org.apache.hadoop.hive.llap.io.encoded.OrcEncodedDataReader.callInternal(OrcEncodedDataReader.java:93)
{code}

> LLAP: ORC cache NPE without FileID support
> ------------------------------------------
>
>                 Key: HIVE-12990
>                 URL: https://issues.apache.org/jira/browse/HIVE-12990
>             Project: Hive
>          Issue Type: Bug
>          Components: llap
>    Affects Versions: 2.1.0
>            Reporter: Gopal V
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-12990.patch
>
>
> {code}
>    OrcBatchKey stripeKey = hasFileId ? new OrcBatchKey(fileId, -1, 0) : null;
>    ...
>           if (hasFileId && metadataCache != null) {
>             stripeKey.stripeIx = stripeIx;
>             stripeMetadata = metadataCache.getStripeMetadata(stripeKey);
>           }
> ...
>   public void setStripeMetadata(OrcStripeMetadata m) {
>     assert stripes != null;
>     stripes[m.getStripeIx()] = m;
>   }
> {code}
> {code}
> Caused by: java.lang.NullPointerException
>         at org.apache.hadoop.hive.llap.io.metadata.OrcStripeMetadata.getStripeIx(OrcStripeMetadata.java:106)
>         at org.apache.hadoop.hive.llap.io.decode.OrcEncodedDataConsumer.setStripeMetadata(OrcEncodedDataConsumer.java:70)
>         at org.apache.hadoop.hive.llap.io.encoded.OrcEncodedDataReader.readStripesMetadata(OrcEncodedDataReader.java:685)
>         at org.apache.hadoop.hive.llap.io.encoded.OrcEncodedDataReader.performDataRead(OrcEncodedDataReader.java:283)
>         at org.apache.hadoop.hive.llap.io.encoded.OrcEncodedDataReader$4.run(OrcEncodedDataReader.java:215)
>         at org.apache.hadoop.hive.llap.io.encoded.OrcEncodedDataReader$4.run(OrcEncodedDataReader.java:212)
>         at java.security.AccessController.doPrivileged(Native Method)
>         at javax.security.auth.Subject.doAs(Subject.java:415)
>         at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657)
>         at org.apache.hadoop.hive.llap.io.encoded.OrcEncodedDataReader.callInternal(OrcEncodedDataReader.java:212)
>         at org.apache.hadoop.hive.llap.io.encoded.OrcEncodedDataReader.callInternal(OrcEncodedDataReader.java:93)
>         ... 5 more
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)