You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/04/21 14:35:08 UTC
[GitHub] [maven-integration-testing] MartinKanters opened a new pull request #58: [MNG-5571] The --resume-from hint at the end of a failing build shoul…
MartinKanters opened a new pull request #58:
URL: https://github.com/apache/maven-integration-testing/pull/58
…d hint the first topologically sorted failed build, instead of the first one chronologically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters commented on a change in pull request #58: [MNG-5571] The --resume-from hint at the end of a failing build shoul…
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #58:
URL: https://github.com/apache/maven-integration-testing/pull/58#discussion_r446550483
##########
File path: core-it-suite/src/test/resources/mng-5571-multiple-failed-projects-rf-hint/c/pom.xml
##########
@@ -0,0 +1,53 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.maven.its.mng5571</groupId>
+ <artifactId>parent</artifactId>
+ <version>0.1-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>c</artifactId>
+ <version>0.1-SNAPSHOT</version>
Review comment:
Nice find! Although I'll have to close this pull request I'm afraid. I'll add a global comment to this PR with the reasoning why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters commented on pull request #58: [MNG-5571] The --resume-from hint at the end of a failing build shoul…
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on pull request #58:
URL: https://github.com/apache/maven-integration-testing/pull/58#issuecomment-650592974
By fixing [MNG-5760](https://issues.apache.org/jira/browse/MNG-5760) we have introduced the `--resume` feature. With this feature the hint at the bottom of the build log will advise to use `-r`. It will only fallback to `-rf :<artifactId>` if the resume.properties file could not be created (because of a filesystem issue). This scenario is very hard, if not impossible, to create in an integration test, so I'm afraid we'll have to close this PR. [The original PR](https://github.com/apache/maven/pull/340) in maven-core is still valid.
If anybody has a suggestion how to fix this, please let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a change in pull request #58: [MNG-5571] The --resume-from hint at the end of a failing build shoul…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #58:
URL: https://github.com/apache/maven-integration-testing/pull/58#discussion_r445769927
##########
File path: core-it-suite/src/test/resources/mng-5571-multiple-failed-projects-rf-hint/c/pom.xml
##########
@@ -0,0 +1,53 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.maven.its.mng5571</groupId>
+ <artifactId>parent</artifactId>
+ <version>0.1-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>c</artifactId>
+ <version>0.1-SNAPSHOT</version>
Review comment:
You can safely inherit this from parent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] rfscholte commented on pull request #58: [MNG-5571] The --resume-from hint at the end of a failing build shoul…
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #58:
URL: https://github.com/apache/maven-integration-testing/pull/58#issuecomment-647043499
please rebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters commented on pull request #58: [MNG-5571] The --resume-from hint at the end of a failing build shoul…
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on pull request #58:
URL: https://github.com/apache/maven-integration-testing/pull/58#issuecomment-649753149
> please rebase
@rfscholte done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters closed pull request #58: [MNG-5571] The --resume-from hint at the end of a failing build shoul…
Posted by GitBox <gi...@apache.org>.
MartinKanters closed pull request #58:
URL: https://github.com/apache/maven-integration-testing/pull/58
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org