You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/10/14 16:40:13 UTC
[GitHub] [nifi] exceptionfactory opened a new pull request, #6535: NIFI-10652 Correct dependency scopes for nifi-iceberg-processors
exceptionfactory opened a new pull request, #6535:
URL: https://github.com/apache/nifi/pull/6535
# Summary
[NIFI-10652](https://issues.apache.org/jira/browse/NIFI-10652) Corrects dependency scoping for `nifi-iceberg-processors` and `nifi-iceberg-processors-nar` to avoid unnecessary duplication of dependencies available in `nifi-iceberg-services-api-nar`. The changes reduce the size of `nifi-iceberg-processors-nar` from over 110 MB to around 20 MB.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [X] Build completed using `mvn clean install -P contrib-check`
- [X] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #6535: NIFI-10652 Correct dependency scopes for nifi-iceberg-processors
Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #6535: NIFI-10652 Correct dependency scopes for nifi-iceberg-processors
URL: https://github.com/apache/nifi/pull/6535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #6535: NIFI-10652 Correct dependency scopes for nifi-iceberg-processors
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6535:
URL: https://github.com/apache/nifi/pull/6535#issuecomment-1282757391
+1 LGTM, thanks for the improvments and review! Merging to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6535: NIFI-10652 Correct dependency scopes for nifi-iceberg-processors
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6535:
URL: https://github.com/apache/nifi/pull/6535#issuecomment-1282349765
Thanks for the review and testing @mark-bathori!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mark-bathori commented on pull request #6535: NIFI-10652 Correct dependency scopes for nifi-iceberg-processors
Posted by GitBox <gi...@apache.org>.
mark-bathori commented on PR #6535:
URL: https://github.com/apache/nifi/pull/6535#issuecomment-1282043245
Hi @exceptionfactory, thanks for checking the dependency scope correctness. I've tested the processor and it works properly with your changes.
PR looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org