You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/11/16 17:47:46 UTC
[GitHub] [hive] deniskuzZ opened a new pull request #2796: HIVE-25710: Config used to enable non-blocking TRUNCATE is not proper…
deniskuzZ opened a new pull request #2796:
URL: https://github.com/apache/hive/pull/2796
…ly propagated
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #2796: HIVE-25710: Config used to enable non-blocking TRUNCATE is not proper…
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #2796:
URL: https://github.com/apache/hive/pull/2796#discussion_r758329397
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/truncate/TruncateTableAnalyzer.java
##########
@@ -116,10 +116,13 @@ private void checkTruncateEligibility(ASTNode ast, ASTNode root, String tableNam
private void addTruncateTableOutputs(ASTNode root, Table table, Map<String, String> partitionSpec)
throws SemanticException {
- boolean truncateKeepsDataFiles = AcidUtils.isTransactionalTable(table) &&
- MetastoreConf.getBoolVar(conf, MetastoreConf.ConfVars.TRUNCATE_ACID_USE_BASE);
+ boolean truncateUseBase = (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVE_ACID_TRUNCATE_USE_BASE)
+ || HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVE_ACID_LOCKLESS_READS_ENABLED))
Review comment:
If it was never working, we do not need to deprecate it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #2796: HIVE-25710: Config used to enable non-blocking TRUNCATE is not proper…
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #2796:
URL: https://github.com/apache/hive/pull/2796#discussion_r755102484
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##########
@@ -1841,39 +1841,47 @@ public void dropTable(String catName, String dbname, String name, boolean delete
}
}
+ @Override
+ public void truncateTable(String dbName, String tableName, List<String> partNames,
+ String validWriteIds, long writeId, boolean deleteData) throws TException {
+ truncateTableInternal(getDefaultCatalog(conf),
+ dbName, tableName, partNames, validWriteIds, writeId, deleteData);
+ }
+
@Override
public void truncateTable(String dbName, String tableName, List<String> partNames,
String validWriteIds, long writeId) throws TException {
truncateTableInternal(getDefaultCatalog(conf),
- dbName, tableName, partNames, validWriteIds, writeId);
+ dbName, tableName, partNames, validWriteIds, writeId, true);
}
@Override
public void truncateTable(String dbName, String tableName, List<String> partNames) throws TException {
- truncateTableInternal(getDefaultCatalog(conf), dbName, tableName, partNames, null, -1);
+ truncateTableInternal(getDefaultCatalog(conf), dbName, tableName, partNames, null, -1, true);
}
@Override
public void truncateTable(String catName, String dbName, String tableName, List<String> partNames)
throws TException {
- truncateTableInternal(catName, dbName, tableName, partNames, null, -1);
+ truncateTableInternal(catName, dbName, tableName, partNames, null, -1, true);
}
private void truncateTableInternal(String catName, String dbName, String tableName,
- List<String> partNames, String validWriteIds, long writeId)
- throws MetaException, TException {
+ List<String> partNames, String validWriteIds, long writeId, boolean deleteData)
+ throws TException {
Table table = getTable(catName, dbName, tableName);
HiveMetaHook hook = getHook(table);
- EnvironmentContext envContext = new EnvironmentContext();
+ EnvironmentContext context = new EnvironmentContext();
+ context.putToProperties("truncateSkipDataDeletion", Boolean.toString(!deleteData));
Review comment:
yea, I'll fix that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #2796: HIVE-25710: Config used to enable non-blocking TRUNCATE is not proper…
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #2796:
URL: https://github.com/apache/hive/pull/2796#discussion_r755076336
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
##########
@@ -1397,9 +1397,6 @@ public static ConfVars getMetaConf(String name) {
" If org.apache.hive.hcatalog.listener.DbNotificationListener is configured along with other transactional event" +
" listener implementation classes, make sure org.apache.hive.hcatalog.listener.DbNotificationListener is placed at" +
" the end of the list."),
- TRUNCATE_ACID_USE_BASE("metastore.acid.truncate.usebase", "hive.metastore.acid.truncate.usebase", false,
Review comment:
How old is this config? Is this released somewhere? Shall we deprecate it, or it is ok to remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ merged pull request #2796: HIVE-25710: Config used to enable non-blocking TRUNCATE is not proper…
Posted by GitBox <gi...@apache.org>.
deniskuzZ merged pull request #2796:
URL: https://github.com/apache/hive/pull/2796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #2796: HIVE-25710: Config used to enable non-blocking TRUNCATE is not proper…
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #2796:
URL: https://github.com/apache/hive/pull/2796#discussion_r755073760
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -3060,8 +3060,15 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
"Creates an _orc_acid_version file along with acid files, to store the version data"),
HIVE_TXN_READONLY_ENABLED("hive.txn.readonly.enabled", false,
- "Enables read-only transaction classification and related optimizations"),
-
+ "Enables read-only transaction classification and related optimizations"),
+
+ HIVE_ACID_LOCKLESS_READS_ENABLED("hive.acid.lockless.reads.enabled", false,
Review comment:
Where will we document the requirements when this lockless reads can work?
Like `HIVE_ACID_TRUNCATE_USE_BASE` should be true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #2796: HIVE-25710: Config used to enable non-blocking TRUNCATE is not proper…
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #2796:
URL: https://github.com/apache/hive/pull/2796#discussion_r755075666
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##########
@@ -1841,39 +1841,47 @@ public void dropTable(String catName, String dbname, String name, boolean delete
}
}
+ @Override
+ public void truncateTable(String dbName, String tableName, List<String> partNames,
+ String validWriteIds, long writeId, boolean deleteData) throws TException {
+ truncateTableInternal(getDefaultCatalog(conf),
+ dbName, tableName, partNames, validWriteIds, writeId, deleteData);
+ }
+
@Override
public void truncateTable(String dbName, String tableName, List<String> partNames,
String validWriteIds, long writeId) throws TException {
truncateTableInternal(getDefaultCatalog(conf),
- dbName, tableName, partNames, validWriteIds, writeId);
+ dbName, tableName, partNames, validWriteIds, writeId, true);
}
@Override
public void truncateTable(String dbName, String tableName, List<String> partNames) throws TException {
- truncateTableInternal(getDefaultCatalog(conf), dbName, tableName, partNames, null, -1);
+ truncateTableInternal(getDefaultCatalog(conf), dbName, tableName, partNames, null, -1, true);
}
@Override
public void truncateTable(String catName, String dbName, String tableName, List<String> partNames)
throws TException {
- truncateTableInternal(catName, dbName, tableName, partNames, null, -1);
+ truncateTableInternal(catName, dbName, tableName, partNames, null, -1, true);
}
private void truncateTableInternal(String catName, String dbName, String tableName,
- List<String> partNames, String validWriteIds, long writeId)
- throws MetaException, TException {
+ List<String> partNames, String validWriteIds, long writeId, boolean deleteData)
+ throws TException {
Table table = getTable(catName, dbName, tableName);
HiveMetaHook hook = getHook(table);
- EnvironmentContext envContext = new EnvironmentContext();
+ EnvironmentContext context = new EnvironmentContext();
+ context.putToProperties("truncateSkipDataDeletion", Boolean.toString(!deleteData));
Review comment:
Should `truncateSkipDataDeletion` be a constant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #2796: HIVE-25710: Config used to enable non-blocking TRUNCATE is not proper…
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #2796:
URL: https://github.com/apache/hive/pull/2796#discussion_r755102120
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/truncate/TruncateTableAnalyzer.java
##########
@@ -116,10 +116,13 @@ private void checkTruncateEligibility(ASTNode ast, ASTNode root, String tableNam
private void addTruncateTableOutputs(ASTNode root, Table table, Map<String, String> partitionSpec)
throws SemanticException {
- boolean truncateKeepsDataFiles = AcidUtils.isTransactionalTable(table) &&
- MetastoreConf.getBoolVar(conf, MetastoreConf.ConfVars.TRUNCATE_ACID_USE_BASE);
+ boolean truncateUseBase = (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVE_ACID_TRUNCATE_USE_BASE)
+ || HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVE_ACID_LOCKLESS_READS_ENABLED))
Review comment:
It didn't work (only in tests). Not sure if we need to deprecate old property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #2796: HIVE-25710: Config used to enable non-blocking TRUNCATE is not proper…
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #2796:
URL: https://github.com/apache/hive/pull/2796#discussion_r755103682
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
##########
@@ -1397,9 +1397,6 @@ public static ConfVars getMetaConf(String name) {
" If org.apache.hive.hcatalog.listener.DbNotificationListener is configured along with other transactional event" +
" listener implementation classes, make sure org.apache.hive.hcatalog.listener.DbNotificationListener is placed at" +
" the end of the list."),
- TRUNCATE_ACID_USE_BASE("metastore.acid.truncate.usebase", "hive.metastore.acid.truncate.usebase", false,
Review comment:
it's disabled downstream + it doesn't work correctly as the property activating it is not propagated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a change in pull request #2796: HIVE-25710: Config used to enable non-blocking TRUNCATE is not proper…
Posted by GitBox <gi...@apache.org>.
deniskuzZ commented on a change in pull request #2796:
URL: https://github.com/apache/hive/pull/2796#discussion_r755101210
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -3060,8 +3060,15 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
"Creates an _orc_acid_version file along with acid files, to store the version data"),
HIVE_TXN_READONLY_ENABLED("hive.txn.readonly.enabled", false,
- "Enables read-only transaction classification and related optimizations"),
-
+ "Enables read-only transaction classification and related optimizations"),
+
+ HIVE_ACID_LOCKLESS_READS_ENABLED("hive.acid.lockless.reads.enabled", false,
Review comment:
HIVE_ACID_LOCKLESS_READS_ENABLED is independent from HIVE_ACID_TRUNCATE_USE_BASE. HIVE_ACID_LOCKLESS_READS_ENABLED enables group of non-blocking operations at once like drop/truncate table/partition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #2796: HIVE-25710: Config used to enable non-blocking TRUNCATE is not proper…
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #2796:
URL: https://github.com/apache/hive/pull/2796#discussion_r755074358
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/truncate/TruncateTableAnalyzer.java
##########
@@ -116,10 +116,13 @@ private void checkTruncateEligibility(ASTNode ast, ASTNode root, String tableNam
private void addTruncateTableOutputs(ASTNode root, Table table, Map<String, String> partitionSpec)
throws SemanticException {
- boolean truncateKeepsDataFiles = AcidUtils.isTransactionalTable(table) &&
- MetastoreConf.getBoolVar(conf, MetastoreConf.ConfVars.TRUNCATE_ACID_USE_BASE);
+ boolean truncateUseBase = (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVE_ACID_TRUNCATE_USE_BASE)
+ || HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVE_ACID_LOCKLESS_READS_ENABLED))
Review comment:
What happened with the `TRUNCATE_ACID_USE_BASE` config?
Do we need to deprecate it? Was this used for the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org